Skip to content

[AWS_Logs] Add support for worker count in non_aws_bucket settings#4917

Merged
P1llus merged 2 commits intoelastic:mainfrom
P1llus:package_aws_log_non_aws_workers
Jan 3, 2023
Merged

[AWS_Logs] Add support for worker count in non_aws_bucket settings#4917
P1llus merged 2 commits intoelastic:mainfrom
P1llus:package_aws_log_non_aws_workers

Conversation

@P1llus
Copy link
Copy Markdown
Member

@P1llus P1llus commented Jan 2, 2023 •
edited
Loading

What does this PR do?

Because of the unless statements in the AWS config template, it is not possible to set worker count when using non_aws_bucket_name.

Worker count is a required field, so this will fail.

I also added a default value just in case people forget about the setting.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@P1llus P1llus requested a review from a team as a code owner January 2, 2023 15:13
@P1llus P1llus added Team:Cloud-Monitoring Label for the Cloud Monitoring team Integration:aws AWS labels Jan 2, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jan 2, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-02T15:14:49.689+0000

  • Duration: 14 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jan 2, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 66.667% (2/3) 👍 41.667
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@P1llus P1llus merged commit 963863c into elastic:main Jan 3, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jan 3, 2023

Package aws_logs - 0.3.2 containing this change is available at https://epr.elastic.co/search?package=aws_logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@francescayeye francescayeye francescayeye approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Integration:aws AWS Team:Cloud-Monitoring Label for the Cloud Monitoring team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@P1llus @elasticmachine @francescayeye