Skip to content

[Logstash] Added ssl config support to logstash module#4914

Merged
mohamedhamed-ahmed merged 1 commit intoelastic:mainfrom
mohamedhamed-ahmed:4666-add-ssl-config-to-logstash-module
Jan 9, 2023
Merged

[Logstash] Added ssl config support to logstash module#4914
mohamedhamed-ahmed merged 1 commit intoelastic:mainfrom
mohamedhamed-ahmed:4666-add-ssl-config-to-logstash-module

Conversation

@mohamedhamed-ahmed
Copy link
Copy Markdown
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed commented Jan 2, 2023 •
edited
Loading

What does this PR do?

Add ssl configuration options for logstash integration module

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that the new ssl configuration is being passed properly to the metricbeat module

How to this PR was tested

  • Applied changes locally, and used elastic-package to spawn up a complete stack locally.
  • Made sure the new fields are visible in the UI as below:

Screenshot 2022-12-22 at 15 21 23

  • Checked that the policy has the new fields mapped properly
    Screenshot 2023-01-02 at 15 24 06

  • Spawned an Elastic agent locally and checked the matribeat logs to make sure that it initially fails when connecting to ES and then succeeds to establish a connection to ES when ssl configuration are passed properly

Related issues

@mohamedhamed-ahmed mohamedhamed-ahmed added bug Something isn't working, use only for issues Integration:logstash Logstash draft Draft v8.7.0 Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services labels Jan 2, 2023
@mohamedhamed-ahmed mohamedhamed-ahmed requested a review from a team as a code owner January 2, 2023 11:57
@mohamedhamed-ahmed mohamedhamed-ahmed self-assigned this Jan 2, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jan 2, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-02T11:57:23.268+0000

  • Duration: 18 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 25
Skipped 0
Total 25

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jan 2, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (6/6) 💚 2.01
Classes 100.0% (6/6) 💚 2.01
Methods 100.0% (46/46) 💚 9.449
Lines 87.558% (190/217) 👎 -4.122
Conditionals 100.0% (0/0) 💚

@mohamedhamed-ahmed mohamedhamed-ahmed mentioned this pull request Jan 2, 2023
Closed
4 tasks
@mohamedhamed-ahmed mohamedhamed-ahmed merged commit f12fbd8 into elastic:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@klacabane klacabane klacabane approved these changes

Assignees

@mohamedhamed-ahmed mohamedhamed-ahmed

Labels

bug Something isn't working, use only for issues draft Draft Integration:logstash Logstash Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services v8.7.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mohamedhamed-ahmed @elasticmachine @klacabane