Skip to content

[Kibana] Added ssl config support to kibana module#4912

Merged
mohamedhamed-ahmed merged 2 commits intoelastic:mainfrom
mohamedhamed-ahmed:4666-add-ssl-config-to-kibana-module
Jan 9, 2023
Merged

[Kibana] Added ssl config support to kibana module#4912
mohamedhamed-ahmed merged 2 commits intoelastic:mainfrom
mohamedhamed-ahmed:4666-add-ssl-config-to-kibana-module

Conversation

@mohamedhamed-ahmed
Copy link
Copy Markdown
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed commented Jan 2, 2023 •
edited
Loading

What does this PR do?

Add ssl configuration options for kibana integration module

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that the new ssl configuration is being passed properly to the metricbeat module

How to this PR was tested

  • Applied changes locally, and used elastic-package to spawn up a complete stack locally.
  • Made sure the new fields are visible in the UI as below:

Screenshot 2022-12-22 at 15 21 23

  • Checked that the policy has the new fields mapped properly
    Screenshot 2023-01-02 at 15 19 23

  • Spawned an Elastic agent locally and checked the matribeat logs to make sure that it initially fails when connecting to ES and then succeeds to establish a connection to ES when ssl configuration are passed properly

Related issues

@mohamedhamed-ahmed mohamedhamed-ahmed added bug Something isn't working, use only for issues Integration:kibana Kibana draft Draft v8.7.0 Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services labels Jan 2, 2023
@mohamedhamed-ahmed mohamedhamed-ahmed requested a review from a team as a code owner January 2, 2023 10:33
@mohamedhamed-ahmed mohamedhamed-ahmed self-assigned this Jan 2, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jan 2, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-09T09:54:30.797+0000

  • Duration: 30 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 28
Skipped 0
Total 28

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jan 2, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 94.872% (37/39) 👍 1.538
Lines 87.234% (82/94) 👎 -12.766
Conditionals 100.0% (0/0) 💚

@mohamedhamed-ahmed mohamedhamed-ahmed force-pushed the 4666-add-ssl-config-to-kibana-module branch from bc8041b to 212af84 Compare January 2, 2023 11:55
@mohamedhamed-ahmed mohamedhamed-ahmed mentioned this pull request Jan 2, 2023
Closed
4 tasks
@mohamedhamed-ahmed mohamedhamed-ahmed removed the draft Draft label Jan 2, 2023
klacabane
klacabane reviewed Jan 5, 2023
View reviewed changes
@mohamedhamed-ahmed mohamedhamed-ahmed merged commit 1ef1e29 into elastic:main Jan 9, 2023
@alstolten alstolten mentioned this pull request Mar 21, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@klacabane klacabane klacabane approved these changes

Assignees

@mohamedhamed-ahmed mohamedhamed-ahmed

Labels

bug Something isn't working, use only for issues Integration:kibana Kibana Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services v8.7.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mohamedhamed-ahmed @elasticmachine @klacabane