Skip to content

Inline awsfargate integration dashboard#4769

Merged
kaiyan-sheng merged 2 commits intoelastic:mainfrom
kaiyan-sheng:inline_awsfargate
Dec 7, 2022
Merged

Inline awsfargate integration dashboard#4769
kaiyan-sheng merged 2 commits intoelastic:mainfrom
kaiyan-sheng:inline_awsfargate

Conversation

@kaiyan-sheng
Copy link
Copy Markdown

@kaiyan-sheng kaiyan-sheng commented Dec 6, 2022 •
edited
Loading

What does this PR do?

This PR is to inline all visualizations into their respective dashboards and deletes the individual visualization saved objects using https://github.com/flash1293/legacy_vis_analyzer

Command that I ran:

KIBANA="https://elastic:changeme@localhost:5601" NODE_TLS_REJECT_UNAUTHORIZED='0' node inline.js ./integrations/packages/awsfargate/kibana/

Output:

Prepared 1 visualizations to be inlined
Prepared 7 lenss to be inlined
Processing dashboard [AWS Fargate] Fargate Overview
Inlined a vis, pushed 3 inner references
Inlined a lens, pushed 2 inner references
Inlined a lens, pushed 2 inner references
Inlined a lens, pushed 2 inner references
Inlined a lens, pushed 2 inner references
Inlined a lens, pushed 2 inner references
Inlined a lens, pushed 2 inner references
Inlined a lens, pushed 2 inner references
Inlined 1 visualizations
Inlined 0 maps
Inlined 7 lenses
Removing visualization folder
Removing lens folder
Writing back dashboards

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner December 6, 2022 18:20
@kaiyan-sheng kaiyan-sheng self-assigned this Dec 6, 2022
@kaiyan-sheng kaiyan-sheng added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Dec 6, 2022
@zmoog
Copy link
Copy Markdown
Contributor

zmoog commented Dec 6, 2022

Hey @kaiyan-sheng, thank you for including the steps to inline individual visualization in the dashboard!

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Dec 6, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-06T18:21:39.436+0000

  • Duration: 14 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Dec 6, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 66.667% (2/3) 👎 -33.333
Lines 100.0% (0/0) 💚 4.661
Conditionals 100.0% (0/0) 💚

@zmoog zmoog self-requested a review December 6, 2022 18:38
zmoog
zmoog approved these changes Dec 6, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran a quick check on the integration, and it LGTM!

CleanShot 2022-12-06 at 23 36 00@2x

@kaiyan-sheng
Copy link
Copy Markdown
Author

kaiyan-sheng commented Dec 7, 2022

@zmoog I got stuck yesterday trying to run the script so I thought better to put it there in the description for future reference 😬 Thanks for the review and testing!!!

@kaiyan-sheng kaiyan-sheng merged commit f9afcc0 into elastic:main Dec 7, 2022
@kaiyan-sheng kaiyan-sheng deleted the inline_awsfargate branch December 7, 2022 15:46
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Dec 7, 2022

Package awsfargate - 0.2.0 containing this change is available at https://epr.elastic.co/search?package=awsfargate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmoog zmoog zmoog approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels

Team:Cloud-Monitoring Label for the Cloud Monitoring team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate awsfargate dashboards to by value

3 participants

@kaiyan-sheng @zmoog @elasticmachine