Skip to content

[Enhancement] [AWS Security Hub] Update the Pagination Termination Condition#4703

Merged
P1llus merged 2 commits intoelastic:mainfrom
vinit-chauhan:package-aws-security-hub-1.27.2
Nov 29, 2022
Merged

[Enhancement] [AWS Security Hub] Update the Pagination Termination Condition#4703
P1llus merged 2 commits intoelastic:mainfrom
vinit-chauhan:package-aws-security-hub-1.27.2

Conversation

@vinit-chauhan
Copy link
Copy Markdown
Contributor

@vinit-chauhan vinit-chauhan commented Nov 23, 2022

Type of change

  • Enhancement

What does this PR do?

Update the Pagination Termination Condition for AWS Security Hub connector.

Current condition for pagination termination contains [[else]][[.last_response.terminate_pagination]][[end]] which results in error logs when pagination is completed.

Removing this else condition will not result in error logs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/aws directory.
  • Run the following command to run tests.

elastic-package test

Related issues

Screenshots

image
image
image

@vinit-chauhan vinit-chauhan requested a review from a team as a code owner November 23, 2022 10:44
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 23, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 23, 2022

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 23, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-23T10:47:06.204+0000

  • Duration: 37 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 177
Skipped 3
Total 180

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 23, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (14/14) 💚
Files 93.333% (14/15) ❕
Classes 93.333% (14/15) ❕
Methods 85.098% (217/255) ❕
Lines 95.949% (5897/6146) ❕
Conditionals 100.0% (0/0) 💚

P1llus
P1llus approved these changes Nov 25, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a minor fix @vinit-elastic , then I can merge it

packages/aws/data_stream/cloudfront_logs/fields/agent.yml
@@ -32,3 +32,4 @@
example: "stretch"
Copy link
Copy Markdown
Member

@P1llus P1llus Nov 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are linting all the yml files for all the data_streams here, please remove it

Copy link
Copy Markdown
Contributor Author

@vinit-chauhan vinit-chauhan Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @P1llus, There is one pull request that has been merged in main that removes the last line of all agent.yml files. As a result, we must include the final line in all files; otherwise, the elastic-package check will fail.

@P1llus
Copy link
Copy Markdown
Member

P1llus commented Nov 29, 2022

Double checked with @kaiyan-sheng on the changes to agent.yml, it was indeed necessary, so we will go ahead and merge.

@P1llus P1llus merged commit 5fd1df8 into elastic:main Nov 29, 2022
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 29, 2022

Package aws - 1.27.2 containing this change is available at https://epr.elastic.co/search?package=aws

@vinit-chauhan vinit-chauhan deleted the package-aws-security-hub-1.27.2 branch April 1, 2026 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@P1llus P1llus Awaiting requested review from P1llus

1 more reviewer

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request Integration:aws AWS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vinit-chauhan @elasticmachine @P1llus @kaiyan-sheng