Skip to content

windows: fix hbs syntax for translate_sid processor in forwarded stream#4634

Merged
leehinman merged 1 commit intoelastic:mainfrom
efd6:4631-windows
Nov 14, 2022
Merged

windows: fix hbs syntax for translate_sid processor in forwarded stream#4634
leehinman merged 1 commit intoelastic:mainfrom
efd6:4631-windows

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Nov 14, 2022

What does this PR do?

This fixes an indentation error due to whitespace prefix trimming in the UI.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:windows Windows labels Nov 14, 2022
@efd6 efd6 self-assigned this Nov 14, 2022
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 14, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-14T07:35:37.928+0000

  • Duration: 17 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 129
Skipped 0
Total 129

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 14, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 87.5% (7/8) 👎 -9.97
Classes 87.5% (7/8) 👎 -9.97
Methods 83.516% (76/91) 👎 -7.364
Lines 92.714% (5039/5435) 👍 1.018
Conditionals 100.0% (0/0) 💚

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 14, 2022

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 marked this pull request as ready for review November 14, 2022 07:54
@efd6 efd6 requested review from a team as code owners November 14, 2022 07:54
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 14, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@leehinman leehinman merged commit 931c36a into elastic:main Nov 14, 2022
@efd6 efd6 deleted the 4631-windows branch February 5, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@marc-gr marc-gr marc-gr approved these changes

@leehinman leehinman leehinman approved these changes

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry fearful-symmetry is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@efd6 efd6

Labels

bug Something isn't working, use only for issues Integration:windows Windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[windows] forwarded datastream incorrect indentation of translate_sid processor

5 participants

@efd6 @elasticmachine @andrewkroh @marc-gr @leehinman