Skip to content

juniper_*,m365_defender,microsoft_defender_endpoint,mimecast,modsecurity: remove duplicate fields#4611

Merged
efd6 merged 1 commit intoelastic:mainfrom
efd6:4398-jm
Nov 29, 2022
Merged

juniper_*,m365_defender,microsoft_defender_endpoint,mimecast,modsecurity: remove duplicate fields#4611
efd6 merged 1 commit intoelastic:mainfrom
efd6:4398-jm

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Nov 10, 2022

What does this PR do?

This removes duplicate field definitions from juniper_junos, juniper_netscreen, juniper_srx, m365_defender, microsoft_defender_endpoint, mimecast and modsecurity.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Nov 10, 2022
@efd6 efd6 added Team:Security-External Integrations Integration:juniper_srx Juniper SRX Integration:mimecast Mimecast (Partner supported) Integration:modsecurity ModSecurity Audit (Community supported) Integration:microsoft_defender_endpoint Microsoft Defender for Endpoint Integration:m365_defender Microsoft Defender XDR labels Nov 10, 2022
@efd6 efd6 mentioned this pull request Nov 10, 2022
Closed
60 tasks
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 10, 2022 •
edited
Loading

🚀 Benchmarks report

Package microsoft_defender_endpoint 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 2754.82 1890.36 -864.46 (-31.38%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 10, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-10T03:38:33.206+0000

  • Duration: 20 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 123
Skipped 0
Total 123

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 10, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 100.0% (23/23) 💚 2.083
Classes 100.0% (23/23) 💚 2.083
Methods 94.118% (240/255) 👍 2.815
Lines 84.802% (5641/6652) 👎 -5.894
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review November 10, 2022 04:47
@efd6 efd6 requested a review from a team as a code owner November 10, 2022 04:47
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 10, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 added the bug Something isn't working, use only for issues label Nov 14, 2022
kcreddy
kcreddy approved these changes Nov 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit e23f14f into elastic:main Nov 29, 2022
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 29, 2022

Package juniper_junos - 0.5.1 containing this change is available at https://epr.elastic.co/search?package=juniper_junos

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 29, 2022

Package juniper_netscreen - 0.5.1 containing this change is available at https://epr.elastic.co/search?package=juniper_netscreen

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 29, 2022

Package juniper_srx - 1.6.1 containing this change is available at https://epr.elastic.co/search?package=juniper_srx

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 29, 2022

Package m365_defender - 1.4.1 containing this change is available at https://epr.elastic.co/search?package=m365_defender

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 29, 2022

Package microsoft_defender_endpoint - 2.5.1 containing this change is available at https://epr.elastic.co/search?package=microsoft_defender_endpoint

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 29, 2022

Package mimecast - 1.4.1 containing this change is available at https://epr.elastic.co/search?package=mimecast

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 29, 2022

Package modsecurity - 1.4.1 containing this change is available at https://epr.elastic.co/search?package=modsecurity

@efd6 efd6 deleted the 4398-jm branch February 5, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@efd6 efd6

Labels

bug Something isn't working, use only for issues Integration:juniper_srx Juniper SRX Integration:m365_defender Microsoft Defender XDR Integration:microsoft_defender_endpoint Microsoft Defender for Endpoint Integration:mimecast Mimecast (Partner supported) Integration:modsecurity ModSecurity Audit (Community supported)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@efd6 @elasticmachine @kcreddy