Skip to content

hid_bravura_monitor,imperva,infoblox_*,zscalar_*: remove duplicate fields#4610

Merged
efd6 merged 1 commit intoelastic:mainfrom
efd6:4398-hiz
Nov 29, 2022
Merged

hid_bravura_monitor,imperva,infoblox_*,zscalar_*: remove duplicate fields#4610
efd6 merged 1 commit intoelastic:mainfrom
efd6:4398-hiz

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Nov 9, 2022

What does this PR do?

This removes duplicate field definitions in hid_bravura_monitor, imperva, infoblox_bloxoneddi, infoblox_nios ,zscalar_zia and zscalar_zpa.

It also makes minor bugfixes in two packages.

  • markdown syntax for proxy_url description in infoblox_bloxone_ddi
  • normalization of x509.issuer.common_name in zpa

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 9, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-29T06:33:06.877+0000

  • Duration: 22 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 261
Skipped 0
Total 261

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6 efd6 self-assigned this Nov 9, 2022
@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:infoblox_nios Infoblox NIOS Integration:infoblox_bloxone_ddi Infoblox BloxOne DDI Integration:imperva Imperva Integration:zscaler_zpa Zscaler Private Access Integration:zscaler_zia Zscaler Internet Access labels Nov 9, 2022
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 9, 2022 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 9, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 100.0% (20/20) 💚 3.828
Classes 100.0% (20/20) 💚 3.828
Methods 98.319% (234/238) 👍 11.998
Lines 94.429% (6729/7126) 👍 0.341
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review November 9, 2022 23:22
@efd6 efd6 requested a review from a team as a code owner November 9, 2022 23:22
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 9, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 added the Integration:hid_bravura_monitor Bravura Monitor (Partner supported) label Nov 9, 2022
@efd6 efd6 mentioned this pull request Nov 10, 2022
Closed
60 tasks
kcreddy
kcreddy approved these changes Nov 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@kcreddy kcreddy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 Just minor clarifications and resolving conflicts.

  1. zscaler_zia.firewall: Couldn't find host.hostname field in ecs.yml

  2. Also, just looking for conformity/preference:

    In imperva these are the duplicates:
    "securesphere": @timestamp base-fields.yml, ecs.yml
    "securesphere": tags base-fields.yml, ecs.yml

    PR removes @timestamp from base-fields.yml but tags from ecs.yml. Is there any preference of one over the other?

@efd6
Copy link
Copy Markdown
Contributor Author

efd6 commented Nov 29, 2022 •
edited
Loading

  1. Yep, it looks like this was removed in 864f94c#diff-1e300be11bf240a33db1347d839996c0a73a33202d0525a8a7b6d67038ee561b. Given this, I don't know how safe this change is. I'll rebase onto main and recheck after fixing the conflicts.
  2. I don't have a real preference. I would love it if there were only one file. I guess my preference is the option that has the lowest amount of text remaining, but what I have done over the full set is not necessarily consistent.

@efd6
hid_bravura_monitor,imperva,infoblox_*,zscalar_*: remove duplicate fi…
af56c8b 
…elds

Also make minor bugfixes in two packages.

* markdown syntax for proxy_url description in infoblox_bloxone_ddi
* normalization of x509.issuer.common_name in zpa
@efd6 efd6 merged commit e025b56 into elastic:main Nov 29, 2022
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 29, 2022

Package hid_bravura_monitor - 1.3.1 containing this change is available at https://epr.elastic.co/search?package=hid_bravura_monitor

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 29, 2022

Package imperva - 0.11.1 containing this change is available at https://epr.elastic.co/search?package=imperva

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 29, 2022

Package infoblox_bloxone_ddi - 0.2.2 containing this change is available at https://epr.elastic.co/search?package=infoblox_bloxone_ddi

1 similar comment
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 29, 2022

Package infoblox_bloxone_ddi - 0.2.2 containing this change is available at https://epr.elastic.co/search?package=infoblox_bloxone_ddi

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 29, 2022

Package infoblox_nios - 1.4.2 containing this change is available at https://epr.elastic.co/search?package=infoblox_nios

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 29, 2022

Package zscaler_zia - 2.6.1 containing this change is available at https://epr.elastic.co/search?package=zscaler_zia

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 29, 2022

Package zscaler_zpa - 1.4.1 containing this change is available at https://epr.elastic.co/search?package=zscaler_zpa

1 similar comment
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 29, 2022

Package zscaler_zpa - 1.4.1 containing this change is available at https://epr.elastic.co/search?package=zscaler_zpa

@kcreddy
Copy link
Copy Markdown
Contributor

kcreddy commented Nov 30, 2022

  1. Yep, it looks like this was removed in 864f94c#diff-1e300be11bf240a33db1347d839996c0a73a33202d0525a8a7b6d67038ee561b. Given this, I don't know how safe this change is. I'll rebase onto main and recheck after fixing the conflicts.
  2. I don't have a real preference. I would love it if there were only one file. I guess my preference is the option that has the lowest amount of text remaining, but what I have done over the full set is not necessarily consistent.

Great, thanks!!

@efd6 efd6 deleted the 4398-hiz branch February 5, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@efd6 efd6

Labels

bug Something isn't working, use only for issues Integration:hid_bravura_monitor Bravura Monitor (Partner supported) Integration:imperva Imperva Integration:infoblox_bloxone_ddi Infoblox BloxOne DDI Integration:infoblox_nios Infoblox NIOS Integration:zscaler_zia Zscaler Internet Access Integration:zscaler_zpa Zscaler Private Access

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@efd6 @elasticmachine @kcreddy