Skip to content

Add system test for Fortinet Fortimanager#439

Merged
andrewkroh merged 2 commits intoelastic:masterfrom
andrewkroh:fortinet-fortimanager-sys-test
Dec 14, 2020
Merged

Add system test for Fortinet Fortimanager#439
andrewkroh merged 2 commits intoelastic:masterfrom
andrewkroh:fortinet-fortimanager-sys-test

Conversation

@andrewkroh
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh commented Dec 3, 2020

What does this PR do?

This adds a system test for Fortinet Fortimanager.

This add field definitions for ecs.version and related.hosts. And it fixes the manifest for the logfile input by specifying template_path: log.yml.hbs.

FAILURE DETAILS:

fortinet/fortimanager :
[0] field "ecs.version" is undefined
[1] field "related.hosts" is undefined
--- Test results for package: fortinet - END   ---

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all datasets collect metrics or logs.

Related issues

@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Dec 3, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #439 updated

  • Start Time: 2020-12-14T15:59:54.684+0000

  • Duration: 27 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 134
Skipped 0
Total 134

@andrewkroh
Copy link
Copy Markdown
Member Author

run tests

@andrewstucki
Copy link
Copy Markdown

@andrewkroh not sure if it makes a difference, but this is one of the generated packages, so I think that it will likely get overwritten or require redoing these manual changes if it gets regenerated.

@andrewkroh
Copy link
Copy Markdown
Member Author

When I'm done (tomorrow I expect) I'm going to have to take all the fixes I made during testing and bring them back to beats and the rsa2elk generator. If this gets regenerated in the meantime then it will have to manually fixed to get the tests to pass.

This add field definitions for `ecs.version` and `related.hosts`. And it fixes the manifest for the logfile input by specifying `template_path: log.yml.hbs`.

    FAILURE DETAILS:

    fortinet/fortimanager :
    [0] field "ecs.version" is undefined
    [1] field "related.hosts" is undefined
    --- Test results for package: fortinet - END   ---
@andrewkroh andrewkroh merged commit 4313ce1 into elastic:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants