Skip to content

cisco_meraki,fortinet_fortigate: fix ECS issues#4283

Merged
efd6 merged 2 commits intoelastic:mainfrom
efd6:ecs8.5-prep
Sep 23, 2022
Merged

cisco_meraki,fortinet_fortigate: fix ECS issues#4283
efd6 merged 2 commits intoelastic:mainfrom
efd6:ecs8.5-prep

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Sep 23, 2022 •
edited
Loading

What does this PR do?

This fixes issues in ECS compliance in the cisco_meraki and fortinet_fortigate packages.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels. [Integration not found in source] Integration:cisco_meraki Cisco Meraki labels Sep 23, 2022
@efd6 efd6 self-assigned this Sep 23, 2022
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 23, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-23T01:18:44.894+0000

  • Duration: 17 min 14 sec

Test stats 🧪

Test Results
Failed 0
Passed 28
Skipped 0
Total 28

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 23, 2022

🚀 Benchmarks report

Package cisco_meraki 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
events 13333.33 8000 -5333.33 (-40%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 23, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (13/13) 💚 2.641
Classes 100.0% (13/13) 💚 2.641
Methods 100.0% (103/103) 💚 10.143
Lines 95.601% (2195/2296) 👍 4.27
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review September 23, 2022 01:37
@efd6 efd6 requested a review from a team as a code owner September 23, 2022 01:37
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 23, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 23, 2022

⚠️ The sha of the head commit of this PR conflicts with #4284. Mergify cannot evaluate rules on this PR. ⚠️

1 similar comment
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 23, 2022

⚠️ The sha of the head commit of this PR conflicts with #4284. Mergify cannot evaluate rules on this PR. ⚠️

kcreddy
kcreddy approved these changes Sep 23, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 9130087 into elastic:main Sep 23, 2022
This was referenced Sep 29, 2022
Closed
Closed
@andrewkroh andrewkroh mentioned this pull request Sep 29, 2022
Merged
@efd6 efd6 deleted the ecs8.5-prep branch February 5, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@efd6 efd6

Labels

bug Something isn't working, use only for issues Integration:cisco_meraki Cisco Meraki Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels. [Integration not found in source]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@efd6 @elasticmachine @kcreddy