Skip to content

Add system test for Cisco Meraki#428

Merged
andrewkroh merged 2 commits intoelastic:masterfrom
andrewkroh:meraki-system-test
Dec 9, 2020
Merged

Add system test for Cisco Meraki#428
andrewkroh merged 2 commits intoelastic:masterfrom
andrewkroh:meraki-system-test

Conversation

@andrewkroh
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh commented Dec 2, 2020

What does this PR do?

Add system test for Cisco Meraki.

The tests identified two issues:

  • Define ecs.version in fields.
  • Change input type from file to logfile.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all datasets collect metrics or logs.

Related issues

@andrewkroh andrewkroh added the enhancement New feature or request label Dec 2, 2020
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Dec 2, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Branch indexing

  • Start Time: 2020-12-08T22:28:46.137+0000

  • Duration: 18 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 73
Skipped 0
Total 73

Define ecs.version in fields.
Change input type from `file` to `logfile`.
@andrewkroh andrewkroh marked this pull request as ready for review December 2, 2020 13:27
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh andrewkroh merged commit a0aea6e into elastic:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants