Use "elastic-package build" to render README.md files.#410
Merged
mtojek merged 5 commits intoelastic:masterfrom Nov 23, 2020
Merged
Use "elastic-package build" to render README.md files.#410mtojek merged 5 commits intoelastic:masterfrom
mtojek merged 5 commits intoelastic:masterfrom
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
|
Pinging @elastic/integrations (Team:Integrations) |
Contributor
Author
|
Most likely I'll have to rebase against the master branch to pull latest changes. |
ycombinator
reviewed
Nov 22, 2020
ycombinator
approved these changes
Nov 23, 2020
Contributor
ycombinator
left a comment
There was a problem hiding this comment.
Left a nitpick but LGTM.
Nice to see more code being removed from the integrations repo in favor of elastic-package usage!
Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adjusts the Integrations repository to latest changes introduced to
elastic-package.Changes:
elastic-packagewill be responsible for rendering README.md files._dev/build/docsdirectory).dryRunPackageRegistryhas been removed as it's covered with package validation (no need to run it twice).How to test this PR locally
CI will verify the Magefile changes.
Related issues