Skip to content

[System] Fix missing field mappings#4084

Merged
efd6 merged 2 commits intoelastic:mainfrom
legoguy1000:4071-system-field
Aug 29, 2022
Merged

[System] Fix missing field mappings#4084
efd6 merged 2 commits intoelastic:mainfrom
legoguy1000:4071-system-field

Conversation

@legoguy1000
Copy link
Copy Markdown
Contributor

@legoguy1000 legoguy1000 commented Aug 27, 2022

What does this PR do?

Fix missing mappings for error.code and error.message.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@legoguy1000 legoguy1000 requested a review from a team as a code owner August 27, 2022 01:50
@legoguy1000 legoguy1000 requested review from cmacknz and rdner August 27, 2022 01:50
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 27, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-28T12:06:06.674+0000

  • Duration: 15 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 273
Skipped 0
Total 273

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Copy Markdown
Contributor

efd6 commented Aug 28, 2022

/test

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 28, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (4/4) 💚 2.896
Classes 100.0% (4/4) 💚 2.896
Methods 60.759% (48/79) 👎 -28.926
Lines 98.793% (2702/2735) 👍 7.042
Conditionals 100.0% (0/0) 💚

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 29, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit bc68534 into elastic:main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmacknz cmacknz cmacknz approved these changes

@efd6 efd6 efd6 approved these changes

@rdner rdner Awaiting requested review from rdner rdner was automatically assigned from elastic/elastic-agent-data-plane

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Possibly System Integration Mapping Issue

4 participants

@legoguy1000 @elasticmachine @efd6 @cmacknz