Skip to content

[windows] add field to translate_sid processor in powershell operational#3989

Merged
leehinman merged 1 commit intoelastic:mainfrom
leehinman:3988_windows_translate_sid
Aug 12, 2022
Merged

[windows] add field to translate_sid processor in powershell operational#3989
leehinman merged 1 commit intoelastic:mainfrom
leehinman:3988_windows_translate_sid

Conversation

@leehinman
Copy link
Copy Markdown
Contributor

@leehinman leehinman commented Aug 11, 2022

What does this PR do?

Adds field to translate_sid processor in powershell operational datastream. Without the required field events can not be processed

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@leehinman leehinman added bug Something isn't working, use only for issues Team:Security-External Integrations labels Aug 11, 2022
@leehinman leehinman requested review from a team as code owners August 11, 2022 21:39
@leehinman leehinman requested review from faec and rdner August 11, 2022 21:39
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 11, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@leehinman leehinman force-pushed the 3988_windows_translate_sid branch from 29fa78b to 09a6f8c Compare August 11, 2022 21:40
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 11, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-11T21:41:01.632+0000

  • Duration: 18 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 126
Skipped 0
Total 126

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 11, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 87.5% (7/8) 👎 -9.506
Classes 87.5% (7/8) 👎 -9.506
Methods 83.146% (74/89) 👎 -6.546
Lines 92.664% (5002/5398) 👍 1.17
Conditionals 100.0% (0/0) 💚

efd6
efd6 approved these changes Aug 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@leehinman leehinman merged commit cfe6fff into elastic:main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 approved these changes

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

No one assigned

Labels

bug Something isn't working, use only for issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[windows] missing field in translate_sid processor

3 participants

@leehinman @elasticmachine @efd6