Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
| @@ -10,7 +10,7 @@ categories: | |||
| - cloud | |||
| release: ga | |||
| conditions: | |||
| kibana.version: "^7.15.0 || ^8.0.0" | |||
| kibana.version: "^8.1.0" | |||
There was a problem hiding this comment.
Before merging we should see if these changes work in 7.17.x
There was a problem hiding this comment.
As mentioned via email, as the aws dashboards are partially very old the inliner script only works for version 8.1 and up
There was a problem hiding this comment.
I tried to install this integration(changing the kibana.version to include 7.17.0 and above) with running 7.17.5 stack version and here is the error I got:
Error installing aws 1.18.1: Document "aws-0eb5a6a0-694f-11ea-b0ac-95d4ecb1fecd" has property "dashboard" which belongs to a more recent version of Kibana [8.1.0]. The last known version is [7.17.3]
There was a problem hiding this comment.
Correct, they only work for 8.1 and above - 7.x or 8.0 is not supported - that's why I adjsuted the min version in the manifest like this
🌐 Coverage report
|
kaiyan-sheng
left a comment
There was a problem hiding this comment.
I tested some of the dashboards with this change and the dashboards do load. But some of them don't show data caused by the known bug in the dashboards in #3703.
drewdaemon
left a comment
There was a problem hiding this comment.
Looked at a random sample of five dashboards and all panels were by-value. Great work!
|
@kaiyan-sheng could you take another look? Had to re-inline due to merge conflicts |
What does this PR do?
Inlines all visualizations into their respective dashboards and deletes the individual visualization saved objects using https://github.com/flash1293/legacy_vis_analyzer
Checklist
- [ ] I have verified that all data streams collect metrics or logs.changelog.ymlfile.Author's Checklist
Related issues
Fixes #3454