[Azure Metrics] Move container_registry metrics from beats to integrations#3629
Merged
tommyers-elastic merged 3 commits intoelastic:mainfrom Jul 8, 2022
Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
Contributor
Author
|
We're probably good to go; it just needs some testing. |
Switch from "container_registry" to "monitor" metricset, add the metrics configuration from beats, and add an ingest pipeline to set the expected field names (`container_registry.*` instead of `azure.metrics.*`).
6a0ecf6 to
5f659dc
Compare
4 tasks
kaiyan-sheng
reviewed
Jul 1, 2022
kaiyan-sheng
left a comment
There was a problem hiding this comment.
LGTM! Could you also update the sample_event.json file please?
kaiyan-sheng
approved these changes
Jul 6, 2022
kaiyan-sheng
left a comment
There was a problem hiding this comment.
Thank you for updating the sample_event.json!! LGTM!
Contributor
Author
|
@tommyers-elastic, thank you, I missed that one 🤦 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is to move lightweight module configuration from Metricbeat into integrations.
Switch from "container_registry" to "monitor" metricset, add the metrics configuration from beats, and add an ingest pipeline to set the expected field names (
azure. container_registry.*instead ofazure.metrics.*).Checklist
changelog.ymlfile.Related issues
Screenshots