windows/powershell: fix regexp constraints in event 800 parameter detail processing#3495
Merged
efd6 merged 1 commit intoelastic:mainfrom Jun 9, 2022
Merged
windows/powershell: fix regexp constraints in event 800 parameter detail processing#3495efd6 merged 1 commit intoelastic:mainfrom
efd6 merged 1 commit intoelastic:mainfrom
Conversation
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
andrewkroh
approved these changes
Jun 9, 2022
andrewkroh
reviewed
Jun 9, 2022
| source: |- | ||
| def parseRawDetail(String raw) { | ||
| Pattern detailRegex = /^(.+)\((.+)\)\:\s*(.+)?$/; | ||
| Pattern detailRegex = /^([^:(]+)\((.+)\)\:\s*(.+)?$/; |
Member
There was a problem hiding this comment.
I don't know the answer, but I'm wondering if these are compiled on each function invocation. If they were outside the function maybe they would only be compiled once per processor execution. No need to change anything.
Contributor
Author
There was a problem hiding this comment.
I just tried that and it fails to compile if they are outside the function definition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This tightens constraints in the regular expression to prevent greedy consumption of the input and regexp complexity explosion.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots