Skip to content

Standardised names and descriptions for security integrations#3478

Merged
kcreddy merged 46 commits intoelastic:mainfrom
kcreddy:main
Jul 19, 2022
Merged

Standardised names and descriptions for security integrations#3478
kcreddy merged 46 commits intoelastic:mainfrom
kcreddy:main

Conversation

@kcreddy
Copy link
Copy Markdown
Contributor

@kcreddy kcreddy commented Jun 7, 2022 •
edited
Loading

What does this PR do?

Updates the package names with standard wording

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@kcreddy kcreddy requested a review from marc-gr June 7, 2022 14:31
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 7, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-18T17:09:29.628+0000

  • Duration: 78 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 1264
Skipped 1
Total 1265

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 7, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (107/107) 💚
Files 96.729% (207/214) 👎 -0.351
Classes 96.729% (207/214) 👎 -0.351
Methods 91.751% (1813/1976) 👍 2.205
Lines 91.79% (31987/34848) 👍 1.925
Conditionals 100.0% (0/0) 💚

@kcreddy kcreddy marked this pull request as ready for review June 8, 2022 06:14
@kcreddy kcreddy requested a review from a team as a code owner June 8, 2022 06:14
jamiehynds
jamiehynds reviewed Jun 14, 2022
View reviewed changes
@jamiehynds
Copy link
Copy Markdown

jamiehynds commented Jun 14, 2022

Thanks for working through these changes @kcreddy. The only one I'm wary of is the httpjson input - I've pinged Serena from the Enterprise Search team, to see if we can come up with a better option. They already have a Custom API integration but hoping we can align on naming.

@kcreddy kcreddy changed the title Standardised names for security integrations Standardised names and descriptions for security integrations Jun 16, 2022
@kcreddy kcreddy requested a review from adriansr July 11, 2022 10:29
zmoog
zmoog approved these changes Jul 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Azure logs part LGTM

@kcreddy kcreddy merged commit 534e517 into elastic:main Jul 19, 2022
@epixa epixa mentioned this pull request Jul 20, 2022
Closed
This was referenced Jul 26, 2022
Merged
Merged
@kcreddy kcreddy mentioned this pull request Jun 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamiehynds jamiehynds jamiehynds left review comments

@zmoog zmoog zmoog approved these changes

@marc-gr marc-gr marc-gr approved these changes

@ishleenk17 ishleenk17 ishleenk17 approved these changes

+2 more reviewers

@serenachou serenachou serenachou left review comments

@adriansr adriansr adriansr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Security Integration Names

8 participants

@kcreddy @elasticmachine @adriansr @jamiehynds @zmoog @serenachou @marc-gr @ishleenk17