Skip to content

[microsoft_dhcp] Fix value of event.type#3445

Merged
jsoriano merged 1 commit intoelastic:mainfrom
jsoriano:microsoft-dhcp-event-type
May 31, 2022
Merged

[microsoft_dhcp] Fix value of event.type#3445
jsoriano merged 1 commit intoelastic:mainfrom
jsoriano:microsoft-dhcp-event-type

Conversation

@jsoriano
Copy link
Member

What does this PR do?

Replaces unexpected value for event.type "stop" with "end".

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

@jsoriano jsoriano self-assigned this May 31, 2022
@jsoriano jsoriano requested a review from a team as a code owner May 31, 2022 11:08
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-31T11:09:10.078+0000

  • Duration: 14 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 6
Skipped 0
Total 6

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚 3.448
Classes 100.0% (3/3) 💚 3.448
Methods 100.0% (19/19) 💚 10.896
Lines 99.184% (608/613) 👍 9.584
Conditionals 100.0% (0/0) 💚

@jsoriano jsoriano merged commit 7dfc645 into elastic:main May 31, 2022
@jsoriano jsoriano deleted the microsoft-dhcp-event-type branch May 31, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

microsoft_dhcp using invalid values according to ECS

3 participants