Skip to content

[nagios_xi] Fix invalid value in ECS field#3441

Merged
jsoriano merged 2 commits intoelastic:mainfrom
jsoriano:remove-pending-invalid-values
May 31, 2022
Merged

[nagios_xi] Fix invalid value in ECS field#3441
jsoriano merged 2 commits intoelastic:mainfrom
jsoriano:remove-pending-invalid-values

Conversation

@jsoriano
Copy link
Member

@jsoriano jsoriano commented May 30, 2022

What does this PR do?

Fixes invalid value of event.kind ECS field, from metrics to metric.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

@jsoriano jsoriano requested a review from ishleenk17 May 30, 2022 17:44
@jsoriano jsoriano requested a review from a team as a code owner May 30, 2022 17:44
@jsoriano jsoriano self-assigned this May 30, 2022
@elasticmachine
Copy link

elasticmachine commented May 30, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-30T18:22:18.437+0000

  • Duration: 15 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 41
Skipped 0
Total 41

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 30, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚 3.505
Classes 100.0% (3/3) 💚 3.505
Methods 97.059% (33/34) 👍 7.698
Lines 95.23% (1138/1195) 👍 4.454
Conditionals 100.0% (0/0) 💚

ishleenk17
ishleenk17 approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks !

@jsoriano jsoriano merged commit ee2288b into elastic:main May 31, 2022
@jsoriano jsoriano deleted the remove-pending-invalid-values branch May 31, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ishleenk17 ishleenk17 ishleenk17 approved these changes

Assignees

@jsoriano jsoriano

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

nagios_xi using invalid field values according to ECS

3 participants

@jsoriano @elasticmachine @ishleenk17