Skip to content

fix ECS schema on system/auth package#3424

Merged
belimawr merged 4 commits intoelastic:mainfrom
belimawr:fix-ecs-fields
Jun 8, 2022
Merged

fix ECS schema on system/auth package#3424
belimawr merged 4 commits intoelastic:mainfrom
belimawr:fix-ecs-fields

Conversation

@belimawr
Copy link
Contributor

@belimawr belimawr commented May 25, 2022 •
edited
Loading

What does this PR do?

This commit fixes the ECS schema on system/auth package.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

## Author's Checklist

How to test this PR locally

go mod edit -replace github.com/elastic/elastic-package=github.com/jsoriano/elastic-package@check-allowed-values
go mod tidy
cd packages/system/data_stream/auth

elastic-package stack up -d -v
eval "$(elastic-package stack shellinit)"

go run github.com/elastic/elastic-package test pipeline -d auth

Related issues

## Screenshots

@belimawr
fix ECS schema on system/auth package
7d2443e 
This commit fixes the ECS schema on system/auth package.

Fixes elastic#3051
@belimawr belimawr requested a review from a team as a code owner May 25, 2022 06:47
@belimawr belimawr requested review from kvch and rdner May 25, 2022 06:47
@elasticmachine
Copy link

elasticmachine commented May 25, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-03T13:06:16.993+0000

  • Duration: 15 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 271
Skipped 0
Total 271

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 25, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (4/4) 💚 3.44
Classes 100.0% (4/4) 💚 3.44
Methods 59.74% (46/77) 👎 -29.122
Lines 98.782% (2676/2709) 👍 9.0
Conditionals 100.0% (0/0) 💚

rdner
rdner reviewed May 25, 2022
View reviewed changes
Copy link
Member

@rdner rdner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test that's using this schema? Was it failing before?

@belimawr
Copy link
Contributor Author

belimawr commented May 30, 2022

Is there a test that's using this schema? Was it failing before?

It's kinda the other way around, tests are being introduced and are failing because some packages don't fully comply with the ECS: elastic/elastic-package#771

@belimawr belimawr requested a review from andrewkroh May 30, 2022 15:49
jsoriano
jsoriano approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewkroh andrewkroh mentioned this pull request May 31, 2022
Closed
andrewkroh
andrewkroh reviewed May 31, 2022
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a changelog entry.

@belimawr
Copy link
Contributor Author

belimawr commented Jun 3, 2022

Can you please add a changelog entry.

Done on ce5e909

@belimawr belimawr requested a review from andrewkroh June 3, 2022 10:10
@jsoriano
Copy link
Member

jsoriano commented Jun 3, 2022

@belimawr you also need to update the version in the manifest.

For next time you can also use elastic-package changelog add, that manages this 🙂

@belimawr belimawr requested review from jsoriano and rdner June 7, 2022 08:12
jsoriano
jsoriano approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@jlind23 jlind23 self-requested a review June 8, 2022 05:30
@belimawr belimawr merged commit 0f30aff into elastic:main Jun 8, 2022
@belimawr belimawr deleted the fix-ecs-fields branch June 8, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsoriano jsoriano jsoriano approved these changes

@jlind23 jlind23 jlind23 approved these changes

@kvch kvch Awaiting requested review from kvch kvch was automatically assigned from elastic/elastic-agent-data-plane

@andrewkroh andrewkroh Awaiting requested review from andrewkroh

@rdner rdner Awaiting requested review from rdner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

system package using invalid field values according to ECS

6 participants

@belimawr @elasticmachine @jsoriano @rdner @andrewkroh @jlind23