Skip to content

network_traffic: fix invalid terms in tls and thrift data sets#3409

Merged
efd6 merged 2 commits intoelastic:mainfrom
efd6:network_traffic_tetris
May 23, 2022
Merged

network_traffic: fix invalid terms in tls and thrift data sets#3409
efd6 merged 2 commits intoelastic:mainfrom
efd6:network_traffic_tetris

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented May 23, 2022

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:network_traffic Network Packet Capture labels May 23, 2022
@efd6 efd6 self-assigned this May 23, 2022
@efd6 efd6 requested a review from a team as a code owner May 23, 2022 11:43
@elasticmachine
Copy link

elasticmachine commented May 23, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

efd6
efd6 commented May 23, 2022
View reviewed changes
@elasticmachine
Copy link

elasticmachine commented May 23, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-23T11:45:10.697+0000

  • Duration: 70 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 264
Skipped 0
Total 264

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 23, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.896
Classes 100.0% (0/0) 💚 3.896
Methods 71.875% (46/64) 👎 -15.962
Lines 100.0% (0/0) 💚 10.841
Conditionals 100.0% (0/0) 💚

@efd6 efd6 merged commit 8e8cf15 into elastic:main May 23, 2022
@andrewkroh andrewkroh mentioned this pull request May 31, 2022
Merged
@efd6 efd6 deleted the network_traffic_tetris branch February 5, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@r00tu53r r00tu53r r00tu53r approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@efd6 efd6

Labels

bug Something isn't working, use only for issues Integration:network_traffic Network Packet Capture

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

network_traffic using invalid ECS values

3 participants

@efd6 @elasticmachine @r00tu53r