network_traffic: remove invalid "network_traffic" terms from event.category#3384
Merged
efd6 merged 2 commits intoelastic:mainfrom May 20, 2022
Merged
network_traffic: remove invalid "network_traffic" terms from event.category#3384efd6 merged 2 commits intoelastic:mainfrom
efd6 merged 2 commits intoelastic:mainfrom
Conversation
708d9d3 to
b6e686b
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
andrewkroh
approved these changes
May 20, 2022
| - script: | ||
| description: Remove invalid "network_traffic" term added by packetbeat prior to v8. | ||
| # This string-based comparison is valid while versions are below v10.x. | ||
| if: 'ctx.agent?.version == null || ctx.agent.version.compareTo("8.") < 0' |
Member
There was a problem hiding this comment.
The only major version that has this issue is 7.x so a startsWith("7.") would work too.
Contributor
Author
There was a problem hiding this comment.
I considered that, but felt this would be clearer/safer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This makes the integration ECS-compliant.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots