Skip to content

system/security: add GeoIP enrichment#3375

Merged
efd6 merged 1 commit intoelastic:mainfrom
efd6:3369-system
May 18, 2022
Merged

system/security: add GeoIP enrichment#3375
efd6 merged 1 commit intoelastic:mainfrom
efd6:3369-system

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented May 18, 2022 •
edited
Loading

What does this PR do?

This add GeoIP enrichment for the source.ip if it's available.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 requested a review from a team May 18, 2022 06:12
@efd6 efd6 requested a review from a team as a code owner May 18, 2022 06:12
@efd6 efd6 self-assigned this May 18, 2022
@efd6 efd6 requested review from kvch and rdner May 18, 2022 06:12
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 18, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 changed the title system/security: add GeoIP enrichement system/security: add GeoIP enrichment May 18, 2022
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 18, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-18T21:54:47.120+0000

  • Duration: 16 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 271
Skipped 0
Total 271

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 18, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (4/4) 💚 3.731
Classes 100.0% (4/4) 💚 3.731
Methods 59.74% (46/77) 👎 -28.753
Lines 98.782% (2676/2709) 👍 9.293
Conditionals 100.0% (0/0) 💚

andrewkroh
andrewkroh approved these changes May 18, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@efd6 efd6 merged commit baff4a4 into elastic:main May 18, 2022
@efd6 efd6 deleted the 3369-system branch February 5, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdner rdner rdner approved these changes

@andrewkroh andrewkroh andrewkroh approved these changes

@kvch kvch Awaiting requested review from kvch kvch was automatically assigned from elastic/elastic-agent-data-plane

Assignees

@efd6 efd6

Labels

enhancement New feature or request Integration:system System

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[system] Missing GeoIP data on ingest pipeline logs-system.security-1.6.4

4 participants

@efd6 @elasticmachine @rdner @andrewkroh