Skip to content

[aws] Fix invalid values for ECS fields#3342

Merged
kaiyan-sheng merged 2 commits intoelastic:mainfrom
kaiyan-sheng:fix_ecs_fields
May 12, 2022
Merged

[aws] Fix invalid values for ECS fields#3342
kaiyan-sheng merged 2 commits intoelastic:mainfrom
kaiyan-sheng:fix_ecs_fields

Conversation

@kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented May 11, 2022 •
edited
Loading

What does this PR do?

This PR is to fix invalid values for ECS fields in AWS integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner May 11, 2022 18:45
@kaiyan-sheng kaiyan-sheng self-assigned this May 11, 2022
@elasticmachine
Copy link

elasticmachine commented May 11, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-12T07:54:47.248+0000

  • Duration: 32 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 328
Skipped 0
Total 328

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 11, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (11/11) 💚
Files 91.667% (11/12) 👎 -4.736
Classes 91.667% (11/12) 👎 -4.736
Methods 82.439% (169/205) 👎 -5.807
Lines 92.673% (2087/2252) 👍 3.56
Conditionals 100.0% (0/0) 💚

@kaiyan-sheng kaiyan-sheng added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label May 11, 2022
@kaiyan-sheng kaiyan-sheng requested a review from jsoriano May 11, 2022 20:39
jsoriano
jsoriano approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it looks good to the team. Thanks!

zmoog
zmoog approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, too.

@kaiyan-sheng kaiyan-sheng merged commit cb4103f into elastic:main May 12, 2022
@kaiyan-sheng kaiyan-sheng deleted the fix_ecs_fields branch May 12, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsoriano jsoriano jsoriano approved these changes

@zmoog zmoog zmoog approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels

Team:Cloud-Monitoring Label for the Cloud Monitoring team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aws using invalid field values according to ECS

4 participants

@kaiyan-sheng @elasticmachine @jsoriano @zmoog