Skip to content

fireeye: fix invalid value in sample event#3331

Merged
efd6 merged 1 commit intoelastic:mainfrom
efd6:3099-fireeye
May 12, 2022
Merged

fireeye: fix invalid value in sample event#3331
efd6 merged 1 commit intoelastic:mainfrom
efd6:3099-fireeye

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented May 11, 2022 •
edited
Loading

What does this PR do?

This fixes the invalid event.type value in the sample event that was missed in #3099.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

See #3016 (comment)

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:fireeye FireEye Network Security (Community supported) labels May 11, 2022
@efd6 efd6 requested a review from a team as a code owner May 11, 2022 12:54
@efd6 efd6 self-assigned this May 11, 2022
@elasticmachine
Copy link

elasticmachine commented May 11, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented May 11, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-12T06:42:09.055+0000

  • Duration: 17 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 11, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (2/2) 💚 3.597
Classes 100.0% (2/2) 💚 3.597
Methods 100.0% (18/18) 💚 11.753
Lines 82.462% (489/593) 👎 -6.651
Conditionals 100.0% (0/0) 💚

efd6
efd6 commented May 11, 2022
View reviewed changes
@efd6 efd6 merged commit a694eb5 into elastic:main May 12, 2022
This was referenced May 22, 2022
Closed
Merged
@efd6 efd6 deleted the 3099-fireeye branch February 5, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@r00tu53r r00tu53r r00tu53r approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@efd6 efd6

Labels

bug Something isn't working, use only for issues Integration:fireeye FireEye Network Security (Community supported)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fireeye using invalid field values according to ECS

3 participants

@efd6 @elasticmachine @r00tu53r