Skip to content

fix ECS schema on system package#3327

Merged
belimawr merged 1 commit intoelastic:mainfrom
belimawr:issue-3051-fix-ECS
May 11, 2022
Merged

fix ECS schema on system package#3327
belimawr merged 1 commit intoelastic:mainfrom
belimawr:issue-3051-fix-ECS

Conversation

@belimawr
Copy link
Contributor

@belimawr belimawr commented May 11, 2022

What does this PR do?

This commit fixes the ECS schema on system/auth package.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

## Author's Checklist
## How to test this PR locally

Related issues

## Screenshots

@belimawr belimawr requested a review from a team as a code owner May 11, 2022 10:46
@belimawr belimawr requested review from faec and rdner May 11, 2022 10:46
@elasticmachine
Copy link

elasticmachine commented May 11, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-11T11:00:05.701+0000

  • Duration: 16 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 270
Skipped 0
Total 270

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@belimawr
fix ECS schema on system package
100b1d1 
This commit fixes the ECS schema on system/auth package.

Fixes elastic#3051
@jlind23
Copy link
Contributor

jlind23 commented May 11, 2022 •
edited
Loading

Some tests are failing as it seems the file is not well formatted.

[2022-05-11T10:54:48.928Z] Error: checking package failed: formatting the integration failed (path: /var/lib/jenkins/workspace/est-manager_integrations_PR-3327/src/github.com/elastic/integrations/packages/system, failFast: true): walking through the integration files failed: formatting file failed (path: /var/lib/jenkins/workspace/est-manager_integrations_PR-3327/src/github.com/elastic/integrations/packages/system/data_stream/auth/_dev/test/pipeline/test-auth-ubuntu1204.log-expected.json): file is not formatted (path: /var/lib/jenkins/workspace/est-manager_integrations_PR-3327/src/github.com/elastic/integrations/packages/system/data_stream/auth/_dev/test/pipeline/test-auth-ubuntu1204.log-expected.json)

@belimawr belimawr force-pushed the issue-3051-fix-ECS branch from f78a4b8 to 100b1d1 Compare May 11, 2022 10:59
@elasticmachine
Copy link

elasticmachine commented May 11, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (4/4) 💚 3.589
Classes 100.0% (4/4) 💚 3.589
Methods 58.667% (44/75) 👎 -29.617
Lines 98.754% (2615/2648) 👍 9.725
Conditionals 100.0% (0/0) 💚

@belimawr belimawr merged commit aff4760 into elastic:main May 11, 2022
@belimawr belimawr deleted the issue-3051-fix-ECS branch May 11, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlind23 jlind23 jlind23 approved these changes

@rdner rdner Awaiting requested review from rdner rdner was automatically assigned from elastic/elastic-agent-data-plane

@faec faec Awaiting requested review from faec faec was automatically assigned from elastic/elastic-agent-data-plane

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

system package using invalid field values according to ECS

3 participants

@belimawr @elasticmachine @jlind23