Skip to content

[system] Add support for 5140 and 5145 events#3299

Merged
mtojek merged 6 commits intoelastic:mainfrom
marc-gr:add-share-sec-events
May 18, 2022
Merged

[system] Add support for 5140 and 5145 events#3299
mtojek merged 6 commits intoelastic:mainfrom
marc-gr:add-share-sec-events

Conversation

@marc-gr
Copy link
Copy Markdown
Contributor

@marc-gr marc-gr commented May 9, 2022

What does this PR do?

Adds support for events 5140 and 5145 to the security pipeline.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related

Closes #2645

@marc-gr marc-gr requested a review from a team as a code owner May 9, 2022 14:08
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 9, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-12T07:55:03.722+0000

  • Duration: 16 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 271
Skipped 0
Total 271

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@jamiehynds
Copy link
Copy Markdown

FYI @randomuserid

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 10, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (4/4) 💚 3.597
Classes 100.0% (4/4) 💚 3.597
Methods 58.667% (44/75) 👎 -29.58
Lines 98.773% (2656/2689) 👍 9.66
Conditionals 100.0% (0/0) 💚

Copy link
Copy Markdown
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtojek mtojek merged commit d9705c1 into elastic:main May 18, 2022
@marc-gr marc-gr deleted the add-share-sec-events branch May 18, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:system System

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[system] security - Add support for network share audit events

5 participants