Skip to content

zeek/kerberos: use valid ECS values for fields#3243

Merged
efd6 merged 1 commit intoelastic:mainfrom
efd6:3052-zeek
May 2, 2022
Merged

zeek/kerberos: use valid ECS values for fields#3243
efd6 merged 1 commit intoelastic:mainfrom
efd6:3052-zeek

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented May 2, 2022 •
edited
Loading

What does this PR do?

Changes values assigned to ECS field to conform to the spec.

  • use "access" for event.type instead of "authentication"
  • add "authentication" to event.category

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:zeek Zeek labels May 2, 2022
@efd6 efd6 requested a review from a team as a code owner May 2, 2022 00:58
@efd6 efd6 self-assigned this May 2, 2022
@elasticmachine
Copy link

elasticmachine commented May 2, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6
zeek/kerberos: use valid ECS values for fields
07111d8 
- use "access" for event.type instead of "authentication"
- add "authentication" to event.category
@elasticmachine
Copy link

elasticmachine commented May 2, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-02T01:00:23.186+0000

  • Duration: 63 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 201
Skipped 0
Total 201

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

r00tu53r
r00tu53r approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@r00tu53r r00tu53r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link

elasticmachine commented May 2, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (38/38) 💚
Files 97.368% (74/76) 👍 0.226
Classes 97.368% (74/76) 👍 0.226
Methods 86.919% (598/688) 👎 -2.134
Lines 93.333% (8106/8685) 👍 3.3
Conditionals 100.0% (0/0) 💚

@efd6 efd6 merged commit 2661439 into elastic:main May 2, 2022
@andrewkroh andrewkroh mentioned this pull request May 2, 2022
Merged
@efd6 efd6 deleted the 3052-zeek branch February 5, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@r00tu53r r00tu53r r00tu53r approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@efd6 efd6

Labels

bug Something isn't working, use only for issues Integration:zeek Zeek

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

zeek using invalid field values according to ECS

3 participants

@efd6 @elasticmachine @r00tu53r