[nagios_xi] 3046: ECS Schema adherence for Nagios-XI fields#3197
Merged
ishleenk17 merged 2 commits intoelastic:mainfrom Apr 27, 2022
Merged
[nagios_xi] 3046: ECS Schema adherence for Nagios-XI fields#3197ishleenk17 merged 2 commits intoelastic:mainfrom
ishleenk17 merged 2 commits intoelastic:mainfrom
Conversation
|
💚 CLA has been signed |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
Contributor
kush-elastic
left a comment
There was a problem hiding this comment.
Can you update the PR Heading: [nagios_xi] 3046: ECS Schema adherence for Nagios-XI fields
Else LGTM!
Contributor
|
/test |
1 similar comment
Member
Author
|
/test |
Member
|
The problem with CLA seems to be caused by the use of local emails in the commits. @ishleenk17 could you please replace these emails in these commits? With an email for what the CLA is valid. |
jsoriano
approved these changes
Apr 26, 2022
Member
jsoriano
left a comment
There was a problem hiding this comment.
Codewise LGTM, there is some issue with CLA.
Member
Author
|
/test |
d7caa4e to
772244b
Compare
772244b to
57b2e3e
Compare
lalit-satapathy
approved these changes
Apr 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checklist
changelog.ymlfile.How to test this PR locally
elastic-package test system -v -g
elastic-package test static -v -g
Related issues