Skip to content

[aws] Fix cloudfront integration grok pattern#3192

Merged
kaiyan-sheng merged 3 commits intoelastic:mainfrom
kaiyan-sheng:cloudfront_logs
Apr 26, 2022
Merged

[aws] Fix cloudfront integration grok pattern#3192
kaiyan-sheng merged 3 commits intoelastic:mainfrom
kaiyan-sheng:cloudfront_logs

Conversation

@kaiyan-sheng
Copy link
Copy Markdown

@kaiyan-sheng kaiyan-sheng commented Apr 25, 2022 •
edited
Loading

What does this PR do?

This PR is to fix the grok pattern for http.response.body.bytes field in cloudfront integration to accept -.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner April 25, 2022 21:12
@kaiyan-sheng kaiyan-sheng self-assigned this Apr 25, 2022
@kaiyan-sheng kaiyan-sheng added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Apr 25, 2022
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Apr 25, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-26T12:56:08.855+0000

  • Duration: 25 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 328
Skipped 0
Total 328

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

sayden
sayden approved these changes Apr 26, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Apr 26, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (11/11) 💚
Files 91.667% (11/12) 👎 -5.392
Classes 91.667% (11/12) 👎 -5.392
Methods 82.439% (169/205) 👎 -5.343
Lines 92.66% (2083/2248) 👍 4.082
Conditionals 100.0% (0/0) 💚

@kaiyan-sheng kaiyan-sheng merged commit bf5630e into elastic:main Apr 26, 2022
@kaiyan-sheng kaiyan-sheng deleted the cloudfront_logs branch April 26, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sayden sayden sayden approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kaiyan-sheng kaiyan-sheng

Labels

Team:Cloud-Monitoring Label for the Cloud Monitoring team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kaiyan-sheng @elasticmachine @sayden