Skip to content

update windows readme#3176

Merged
ellis-elastic merged 7 commits intoelastic:mainfrom
ellis-elastic:windows-docs
Jun 20, 2022
Merged

update windows readme#3176
ellis-elastic merged 7 commits intoelastic:mainfrom
ellis-elastic:windows-docs

Conversation

@ellis-elastic
Copy link
Copy Markdown
Contributor

@ellis-elastic ellis-elastic commented Apr 22, 2022 •
edited
Loading

added link to Microsoft documentation and reworded a link

What does this PR do?

added link to Microsoft documentation and reworded a link

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@ellis-elastic
update readme
9916bee 
added link to Microsoft documentation and reworded a link
@ellis-elastic ellis-elastic added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request labels Apr 22, 2022
@ellis-elastic ellis-elastic requested a review from a team as a code owner April 22, 2022 09:59
@ellis-elastic ellis-elastic changed the title update windowsreadme update windows readme Apr 22, 2022
@ellis-elastic ellis-elastic marked this pull request as draft April 22, 2022 09:59
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Apr 22, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-17T08:33:00.032+0000

  • Duration: 18 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 126
Skipped 0
Total 126

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@ellis-elastic ellis-elastic marked this pull request as ready for review April 25, 2022 12:13
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Apr 27, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 87.5% (7/8) 👎 -8.954
Classes 87.5% (7/8) 👎 -8.954
Methods 84.884% (73/86) 👎 -4.438
Lines 93.376% (4962/5314) 👍 2.518
Conditionals 100.0% (0/0) 💚

@ruflin ruflin added the Team:Service-Integrations Label for the Observability Service Integrations team label Jun 8, 2022
@ellis-elastic ellis-elastic requested review from a team as code owners June 17, 2022 08:32
@ellis-elastic ellis-elastic requested review from belimawr and faec June 17, 2022 08:32
efd6
efd6 approved these changes Jun 17, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after nit is gone.

packages/windows/_dev/build/docs/README.md
# Windows Integration

The Windows package allows you to monitor the Windows os, services, applications etc. Because the Windows integration
The Windows package allows you to monitor the [Windows](https://docs.microsoft.com) os, services, applications etc. Because the Windows integration
Copy link
Copy Markdown
Contributor

@efd6 efd6 Jun 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/os/OS/

@ellis-elastic ellis-elastic merged commit 42dfbf8 into elastic:main Jun 20, 2022
@ellis-elastic ellis-elastic deleted the windows-docs branch June 20, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 approved these changes

@belimawr belimawr Awaiting requested review from belimawr belimawr is a code owner automatically assigned from elastic/elastic-agent-data-plane

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Team:Service-Integrations Label for the Observability Service Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ellis-elastic @elasticmachine @efd6 @ruflin @bmorelli25