[Azure] Fix azure.activitylogs.identity with a a concrete value#3019
Merged
kaiyan-sheng merged 2 commits intoelastic:mainfrom Apr 7, 2022
kaiyan-sheng:azure_activity_logs
Merged
[Azure] Fix azure.activitylogs.identity with a a concrete value#3019kaiyan-sheng merged 2 commits intoelastic:mainfrom kaiyan-sheng:azure_activity_logs
kaiyan-sheng merged 2 commits intoelastic:mainfrom
kaiyan-sheng:azure_activity_logs
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
francescayeye
approved these changes
Apr 7, 2022
| field: azure.activitylogs.location | ||
| target_field: geo.name | ||
| ignore_missing: true | ||
| - rename: |
There was a problem hiding this comment.
if I got it right we where receiving both azure.activitylogs.identity.authorization = {...} and azure.activitylogs.identity = "abc", is this correct?
we now rename azure.activitylogs.identity = "abc" to azure.activitylogs.identity_name = "abc", do we?
Author
There was a problem hiding this comment.
yes, that's right. azure.activitylogs.identity as a keyword is new added by azure seems like instead of an object.
endorama
approved these changes
Apr 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixed
azure.activitylogs.identityfield with a concrete value and tested it with a new format sample activity log.Error log without this fix:
Also with the new format, this PR added
azure.activitylogs.identity_name,azure.activitylogs.tenant_id,azure.activitylogs.levelandazure.activitylogs.operation_versionfields.Checklist
changelog.ymlfile.Related issues