Skip to content

cisco,cisco_duo,cisco_ftd: fix event.outcome and event.type field values#3018

Merged
efd6 merged 7 commits intoelastic:mainfrom
efd6:cisco-ecs
Apr 6, 2022
Merged

cisco,cisco_duo,cisco_ftd: fix event.outcome and event.type field values#3018
efd6 merged 7 commits intoelastic:mainfrom
efd6:cisco-ecs

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Apr 6, 2022

What does this PR do?

This make field values agree with the allowable set according to ECS.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:cisco_duo Cisco Duo labels Apr 6, 2022
@efd6 efd6 requested a review from a team as a code owner April 6, 2022 13:16
@elasticmachine
Copy link

elasticmachine commented Apr 6, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Apr 6, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-06T22:32:37.182+0000

  • Duration: 22 min 19 sec

Test stats 🧪

Test Results
Failed 0
Passed 131
Skipped 0
Total 131

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@andrewkroh andrewkroh mentioned this pull request Apr 6, 2022
Closed
17 tasks
@efd6 efd6 merged commit daf0b67 into elastic:main Apr 6, 2022
@efd6 efd6 deleted the cisco-ecs branch April 6, 2022 22:55
This was referenced Apr 11, 2022
Merged
Merged
@jsoriano
Copy link
Member

jsoriano commented May 11, 2022

Reopening as there seems to be still issues: https://beats-ci.elastic.co/blue/organizations/jenkins/Ingest-manager%2Fintegrations/detail/PR-3017/3/tests

test case failed: one or more problems with fields found in documents: [0] parsing field value failed: field "event.outcome"'s value "failed" is not one of the allowed values (failure, success, unknown)

This was referenced Aug 15, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

No one assigned

Labels

bug Something isn't working, use only for issues Integration:cisco_duo Cisco Duo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@efd6 @elasticmachine @jsoriano @andrewkroh