[windows] Support for Sysmon Registry non-QWORD/DWORD events#2962
Merged
r00tu53r merged 8 commits intoelastic:mainfrom Apr 28, 2022
Merged
[windows] Support for Sysmon Registry non-QWORD/DWORD events#2962r00tu53r merged 8 commits intoelastic:mainfrom
r00tu53r merged 8 commits intoelastic:mainfrom
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
efd6
reviewed
Mar 31, 2022
| "registry": { | ||
| "data": { | ||
| "strings": [ | ||
| "0x12349abc" |
Contributor
There was a problem hiding this comment.
Why is the DWORD left as hex but the QWORD above is converted to decimal?
packages/windows/data_stream/sysmon_operational/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
efd6
approved these changes
Apr 1, 2022
|
Pinging @elastic/integrations (Team:Integrations) |
Contributor
Author
|
@elastic/integrations can someone please help review this PR? |
🌐 Coverage report
|
andrewkroh
approved these changes
Apr 28, 2022
Member
andrewkroh
left a comment
There was a problem hiding this comment.
LGTM.
@elastic/integrations, can you please take a look at this.
jsoriano
approved these changes
Apr 28, 2022
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
sysmon_operationalpipeline to process sysmon registry events for values other than QWORD and DWORD (REG_SZ, REG_MULTI_SZ, REG_BINARY, REG_EXPAND_SZ).Checklist
changelog.ymlfile.How to test this PR locally
elastic-package test pipeline -vRelated issues