Skip to content

Add Kubernetes CIS Benchmark integration#2930

Merged
eyalkraft merged 85 commits intomainfrom
unknown repository
Apr 11, 2022
Merged

Add Kubernetes CIS Benchmark integration#2930
eyalkraft merged 85 commits intomainfrom
unknown repository

Conversation

@eyalkraft
Copy link
Copy Markdown
Contributor

@eyalkraft eyalkraft commented Mar 30, 2022

What does this PR do?

Adds the initial version of the Kuberenetes CIS Benchmark integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Notes

  1. As described here currently the package build fails as a result of it containing transforms. This is not a problem in the integration package (there are some packages with transform already - endpoint for example).
example

taken from here

➜  cis_kubernetes_benchmark git:(master) elastic-package build


Build the package
Error: building package failed: invalid content found in built package: found 1 validation error:
   1. item [transform] is not allowed in folder [/Users/eyalkraft/Workspace/elastic/integrations/build/integrations/cis_kubernetes_benchmark/0.0.3/elasticsearch]
  1. For the integration installation to work the Cloud Security Posture Kibana plugin should be enabled.
    This is due to the fact that the tranforms expect some existing indices - these indices are created by the plugin.
    Enabling the plugin is done by setting xpack.cloudSecurityPosture.enabled: true in kibana.yml. By default the plugin is disabled.
    This is documented in the integration doc.
example for installation attempt when the plugin isn't enabled

image

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

David.Natchanny and others added 30 commits December 23, 2021 15:15
* initial package info

* Make kubebeat work with integration inputs

* working integration v1(ILM issue exists in bit)

* fixed files

Co-authored-by: Aleksandr Maus <aleksandr.maus@elastic.co>
update index pattern acording to cloudbeat change
@eyalkraft
Copy link
Copy Markdown
Contributor Author

  1. The plugin is safe! I will open a PR to elastic-package.

@eyalkraft
Copy link
Copy Markdown
Contributor Author

  1. have another attempt at fixing the commits for the CLA

CLA problem solved by signing

@mtojek
Copy link
Copy Markdown
Contributor

mtojek commented Mar 31, 2022

Based on the discussion in elastic/elastic-package#767, it looks like this is a blocker for this issue.

Comment thread .github/CODEOWNERS Outdated
/packages/zscaler_zia @elastic/security-external-integrations
/packages/zscaler_zpa @elastic/security-external-integrations No newline at end of file
/packages/zscaler_zpa @elastic/security-external-integrations
/packages/cis_kubernetes_benchmark @elastic/cloud-posture-security
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please place it accordingly in the alphanum? order?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

title: "Findings"
type: logs
streams:
- input: cloudbeat
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release version bump here: #3003

@eyalkraft eyalkraft marked this pull request as ready for review April 7, 2022 13:09
@eyalkraft eyalkraft requested a review from a team as a code owner April 7, 2022 13:09
Copy link
Copy Markdown
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODEOWNERS LGTM

@eyalkraft eyalkraft merged commit ff96a82 into elastic:main Apr 11, 2022
@kfirpeled kfirpeled deleted the initial-merge-cis-benchmark branch April 14, 2022 18:49
@andrewkroh andrewkroh added the New Integration Issue or pull request for creating a new integration package. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Integration Issue or pull request for creating a new integration package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants