Skip to content

Parse out system Integration, create Linux integration#278

Merged
fearful-symmetry merged 7 commits intoelastic:masterfrom
fearful-symmetry:system-cross-platoform-breakout
Sep 25, 2020
Merged

Parse out system Integration, create Linux integration#278
fearful-symmetry merged 7 commits intoelastic:masterfrom
fearful-symmetry:system-cross-platoform-breakout

Conversation

@fearful-symmetry
Copy link
Copy Markdown
Contributor

@fearful-symmetry fearful-symmetry commented Sep 22, 2020

What does this PR do?

This is in preparation for 7.10. We want to strip the system integration down to just cross-compatible datasets. This will be the first of a few changes for 7.10, the rest will involve cleaning up the existing cross-compatible datasets.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all datasets collect metrics or logs.

Author's Checklist

  • Do we want a custom icon for the Linux Integration?

How to test this PR locally

  • Pull down the PR
  • Build the new package registry
  • Enroll a test agent, make sure the linux and system integrations are properly ingesting data

@fearful-symmetry fearful-symmetry added the enhancement New feature or request label Sep 22, 2020
@fearful-symmetry fearful-symmetry self-assigned this Sep 22, 2020
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 22, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #278 updated]

  • Start Time: 2020-09-25T14:42:19.913+0000

  • Duration: 4 min 48 sec

@andresrc andresrc added the Team:Integrations Label for the Integrations team label Sep 23, 2020
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 23, 2020

Pinging @elastic/integrations (Team:Integrations)

@mtojek
Copy link
Copy Markdown
Contributor

mtojek commented Sep 23, 2020

Please run mage check locally as some files seem to be not formatted well.

@mtojek
Copy link
Copy Markdown
Contributor

mtojek commented Sep 23, 2020 

[2020-09-23T14:23:32.837Z] packages/linux/docs/README.md: needs update
[2020-09-23T14:23:32.837Z] Error: running "git update-index --refresh" failed with exit code 1

Please refresh docs using mage GenerateDocs (also part of mage check).

@fearful-symmetry
Copy link
Copy Markdown
Contributor Author

fearful-symmetry commented Sep 23, 2020

Ah, there we go!

mtojek
mtojek approved these changes Sep 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want a custom icon for the Linux Integration?

I suppose that Tux is a good candidate here.

Overall, LGTM!

@fearful-symmetry fearful-symmetry merged commit d2b9583 into elastic:master Sep 25, 2020
@masci masci mentioned this pull request Nov 19, 2021
Closed
17 tasks
@andrewkroh andrewkroh added Integration:linux Linux Metrics Integration:system System New Integration Issue or pull request for creating a new integration package. labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mukeshelastic mukeshelastic Awaiting requested review from mukeshelastic

1 more reviewer

@mtojek mtojek mtojek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fearful-symmetry fearful-symmetry

Labels

enhancement New feature or request Integration:linux Linux Metrics Integration:system System New Integration Issue or pull request for creating a new integration package. Team:Integrations Label for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fearful-symmetry @elasticmachine @mtojek @andresrc @andrewkroh