[system] Add pipeline to rename process.ppid in process data_stream#2610
Merged
andrewkroh merged 2 commits intoelastic:mainfrom Mar 21, 2022
andrewkroh:system/process-ppid-rename
Merged
[system] Add pipeline to rename process.ppid in process data_stream#2610andrewkroh merged 2 commits intoelastic:mainfrom andrewkroh:system/process-ppid-rename
andrewkroh merged 2 commits intoelastic:mainfrom
andrewkroh:system/process-ppid-rename
Conversation
|
Pinging @elastic/integrations (Team:Integrations) |
Closed
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Member
Author
|
/test |
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Migrate data from Agent 7.x to ECS 8.0 format. Agent 7.x produces process.ppid, but in order to comply with ECS 8.0 we want all data to use process.parent.pid. The process data stream lacked any tests so I added a system test to verify the pipeline works and validate the fields.yml. I found some undocumented fields. Relates #2363 #2512
fearful-symmetry
approved these changes
Mar 15, 2022
Contributor
fearful-symmetry
left a comment
There was a problem hiding this comment.
Looks fine to me, is this something we also want to change on the agent side?
efd6
reviewed
Mar 15, 2022
packages/system/data_stream/process/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Member
Author
It was changed in 8.0 in Beats (https://github.com/elastic/beats/blob/v8.0.0/metricbeat/module/system/process/process.go#L117-L118). So this ensure that data coming from 7.x Agent's will match. |
efd6
approved these changes
Mar 16, 2022
Contributor
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrate data from Agent 7.x to ECS 8.0 format.
Agent 7.x produces process.ppid, but in order to comply with ECS 8.0
we want all data to use process.parent.pid.
The process data stream lacked any tests so I added a system test to
verify the pipeline works and validate the fields.yml. I found some
undocumented fields.
Relates #2363 #2512
Checklist
changelog.ymlfile.Related issues
References