Skip to content

[Uptime] synth package#241

Merged
justinkambic merged 6 commits intoelastic:masterfrom
justinkambic:uptime_synth-package
Aug 19, 2020
Merged

[Uptime] synth package#241
justinkambic merged 6 commits intoelastic:masterfrom
justinkambic:uptime_synth-package

Conversation

@justinkambic
Copy link
Copy Markdown
Contributor

What does this PR do?

We are doing some prototype work for synthetics to get a baseline package configured for our solution.

Our eventual goal is probably not to merge this exact code, but to aid us in the development of our central management story.

How to test this PR locally

Follow the instructions under testing/environments to spin up the environment. The synthetics package should be included in the Ingest Manager when running this branch.

Screenshots

image

@justinkambic justinkambic self-assigned this Aug 6, 2020
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 6, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #241 updated]

  • Start Time: 2020-08-18T18:21:31.822+0000

  • Duration: 5 min 10 sec

Copy link
Copy Markdown
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

As soon as this gets merged, a PR will be opened to put this into snapshot. There it can be tested with the current master build of the agent and Kibana.

@mtojek This is a good example of a package that should go into snapshot but not yet staging or production.

title: Monitor
description: Perform synthetic monitor checks
# config_templates:
# - name: synthetics/http
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see this prototyped on how it might work!

Copy link
Copy Markdown
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a definition for owner. Could you please define a team owning this package? Also, please add the https://github.com/elastic/package-storage to team's repositories with Write permissions.

@justinkambic justinkambic marked this pull request as ready for review August 17, 2020 17:49
@justinkambic
Copy link
Copy Markdown
Contributor Author

@mtojek does 2bb10eb look ok for the owner entry? Our team has access to https://github.com/elastic/package-storage as well.

@mtojek mtojek self-requested a review August 17, 2020 20:17
@justinkambic justinkambic merged commit ab80cda into elastic:master Aug 19, 2020
@andrewkroh andrewkroh added Integration:synthetics Elastic Synthetics New Integration Issue or pull request for creating a new integration package. labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:synthetics Elastic Synthetics New Integration Issue or pull request for creating a new integration package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants