Add custom AWS logs integration for both aws-s3 input and aws-cloudwatch input#2353
Merged
kaiyan-sheng merged 21 commits intoelastic:mainfrom Feb 9, 2022
kaiyan-sheng:add_aws_s3_input
Merged
Add custom AWS logs integration for both aws-s3 input and aws-cloudwatch input#2353kaiyan-sheng merged 21 commits intoelastic:mainfrom kaiyan-sheng:add_aws_s3_input
kaiyan-sheng merged 21 commits intoelastic:mainfrom
kaiyan-sheng:add_aws_s3_input
Conversation
andrewkroh
reviewed
Dec 17, 2021
Member
andrewkroh
left a comment
There was a problem hiding this comment.
Good idea to have a more generic integration for S3.
packages/aws/data_stream/s3_logs/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/aws/data_stream/s3_logs/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
Author
|
@andrewkroh Thank you for the review! Sorry I just got back to this and addressed your comments. |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
andrewkroh
approved these changes
Jan 24, 2022
added 15 commits
January 24, 2022 13:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In the AWS package, we have data streams to parse and ingest several service logs, such as s3access, cloudtrail, vpcflow and etc. This PR is to add the raw s3 input into the AWS package as an option when the specific type of service log is not supported in its own data stream.
We decide to create a separate package called
Custom AWS Logsin integrations and add both aws-s3 input and aws-cloudwatch input options in there. This way, it's aligned with custom logs input, custom TCP/UDP logs input and etc.Checklist
changelog.ymlfile.How to test this PR locally
AWS S3and add itRelated issues
#711