Skip to content

[ML] Fix Nginx ML module manifest query to ignore frozen and cold tiers#2219

Merged
peteharverson merged 2 commits intoelastic:masterfrom
peteharverson:ml-nginx-exclude-frozen-tier
Nov 25, 2021
Merged

[ML] Fix Nginx ML module manifest query to ignore frozen and cold tiers#2219
peteharverson merged 2 commits intoelastic:masterfrom
peteharverson:ml-nginx-exclude-frozen-tier

Conversation

@peteharverson
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson commented Nov 25, 2021 •
edited
Loading

What does this PR do?

The query defined in the json configuration files of anomaly detection modules are run to determine if the module is match for data in the selected index. These queries run over the full time range of the index so can potentially take a long time to return, particularly if searching over documents which are not in the hot or warm data tiers. This PR adds an extra condition to the query to ignore data from the cold and frozen tiers.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Related issues

elastic/kibana#116696

@peteharverson peteharverson added bug Something isn't working, use only for issues Integration:nginx Nginx labels Nov 25, 2021
droberts195
droberts195 approved these changes Nov 25, 2021
View reviewed changes
Copy link
Copy Markdown

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 25, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-25T14:18:46.733+0000

  • Duration: 16 min 22 sec

  • Commit: 0e5cf0f

Test stats 🧪

Test Results
Failed 0
Passed 40
Skipped 0
Total 40

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@peteharverson peteharverson merged commit ee81c87 into elastic:master Nov 25, 2021
@peteharverson peteharverson deleted the ml-nginx-exclude-frozen-tier branch November 25, 2021 17:00
@ebeahan ebeahan mentioned this pull request Aug 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@droberts195 droberts195 droberts195 approved these changes

@mtojek mtojek mtojek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working, use only for issues Integration:nginx Nginx

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@peteharverson @elasticmachine @droberts195 @mtojek