Fix processors configuration in windows and o365 packages#2113
Fix processors configuration in windows and o365 packages#2113adriansr merged 3 commits intoelastic:masterfrom adriansr:fix_processors_conf
Conversation
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
andrewkroh
left a comment
There was a problem hiding this comment.
LGTM, but I did have a question.
| ignore_missing: true | ||
| ignore_failure: true | ||
| map_ecs_fields: true | ||
| {{#if processors.length}} |
There was a problem hiding this comment.
This is using if processors.length while others are using if processors. Any idea why? And could we change this one to be consistent with the others without impacting behavior.
There was a problem hiding this comment.
I see we have 300 usages of if processors and 10 for processors.length. I have no idea what the difference is but both worked fine in my tests.
For now I think it's better to leave this PR as is, each package using its original condition, and evaluate separately if we need to change all packages to use the better of the two kinds of conditions.
/cc @marc-gr as I think he added all the processors.length conditions.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
What does this PR do?
Fixes the processors configuration option for
windowsando365packages.Before this change, trying to add custom processors to any of their data streams resulted in the following error:
Checklist
changelog.ymlfile.[ ] If I'm introducing a new feature, I have modified the Kibana version constraint in my package'smanifest.ymlfile to point to the latest Elastic stack release (e.g.^7.13.0).