Skip to content

apache: changes for unified integration UI#2001

Merged
endorama merged 3 commits intoelastic:masterfrom
endorama:uniform-ui/apache
Nov 2, 2021
Merged

apache: changes for unified integration UI#2001
endorama merged 3 commits intoelastic:masterfrom
endorama:uniform-ui/apache

Conversation

@endorama
Copy link
Copy Markdown
Contributor

@endorama endorama commented Oct 21, 2021

What does this PR do?

Align package title and description for improved Unified Integration UI display.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Author's Checklist

  • promote package to staging
  • promote package to production

How to test this PR locally

Related issues

Screenshots

@endorama endorama added the Team:Integrations Label for the Integrations team label Oct 21, 2021
@endorama endorama self-assigned this Oct 21, 2021
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Oct 21, 2021

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Oct 21, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-25T08:20:05.411+0000

  • Duration: 15 min 55 sec

  • Commit: cea81d5

Test stats 🧪

Test Results
Failed 0
Passed 43
Skipped 0
Total 43

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@endorama endorama changed the title activemq: changes for unified integration UI apache: changes for unified integration UI Oct 21, 2021
@endorama endorama mentioned this pull request Oct 21, 2021
Closed
francescayeye
francescayeye reviewed Oct 21, 2021
View reviewed changes
packages/apache/manifest.yml Outdated
Copy link
Copy Markdown

@francescayeye francescayeye Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to #1901 new tile should be Apache

Copy link
Copy Markdown

@akshay-saraswat akshay-saraswat Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read this thread: #1901 (comment)

francescayeye
francescayeye reviewed Oct 21, 2021
View reviewed changes
packages/apache/manifest.yml Outdated
Copy link
Copy Markdown

@francescayeye francescayeye Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to #1901 description should be Collect logs and metrics from Apache servers with Elastic Agent.

Copy link
Copy Markdown
Contributor Author

@endorama endorama Oct 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now, the the has been removed, so we were looking at the same file but the content changes. I updated the description.

@endorama
Copy link
Copy Markdown
Contributor Author

endorama commented Oct 21, 2021 •
edited
Loading

@aspacca not sure if we are sourcing the information from the same file. I used the Elastic Agent tab in this spreadsheet

My bad, it seems like I was looking at an old version

@endorama endorama merged commit ec90854 into elastic:master Nov 2, 2021
@endorama endorama deleted the uniform-ui/apache branch November 2, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@francescayeye francescayeye Awaiting requested review from francescayeye

1 more reviewer

@akshay-saraswat akshay-saraswat akshay-saraswat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@endorama endorama

Labels

Team:Integrations Label for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@endorama @elasticmachine @francescayeye @akshay-saraswat