[system] Improve user mappings in security#1944
Merged
marc-gr merged 1 commit intoelastic:masterfrom Oct 19, 2021
Merged
Conversation
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
1d30d3b to
e7f9f30
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
P1llus
approved these changes
Oct 19, 2021
Member
P1llus
left a comment
There was a problem hiding this comment.
Small comments, else it looks LGTM
Comment on lines
+2578
to
+2581
| if (ctx?.event?.code == null || | ||
| !["4648", "4688"].contains(ctx.event.code)) { | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
Should we maybe move this out of the script itself? That way it never has to actually execute if its part of the processor conditions.
Comment on lines
+2869
to
+2872
| - set: | ||
| field: user.target.name | ||
| copy_from: winlog.event_data.OldTargetUserName | ||
| ignore_empty_value: true |
Member
There was a problem hiding this comment.
Isn't this already set to another value higher up?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ports changes from elastic/beats#26509 to improve user mappings for security events.
Checklist
changelog.ymlfile.manifest.ymlfile to point to the latest Elastic stack release (e.g.^7.13.0).