Skip to content

[system] prevent pipeline script error#1869

Merged
leehinman merged 3 commits intoelastic:masterfrom
leehinman:system_hashmap_null_safe
Oct 6, 2021
Merged

[system] prevent pipeline script error#1869
leehinman merged 3 commits intoelastic:masterfrom
leehinman:system_hashmap_null_safe

Conversation

@leehinman
Copy link
Copy Markdown
Contributor

@leehinman leehinman commented Oct 6, 2021

What does this PR do?

prevents pipeline script error in system integration

  • make sure value isn't null before creating a new HashMap
  • add test to verify
  • improve error.message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
    - [ ] If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

How to test this PR locally

elastic-package test pipeline

Related issues

@leehinman leehinman added bug Something isn't working, use only for issues Team:Security-External Integrations labels Oct 6, 2021
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Oct 6, 2021

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@leehinman
[system] prevent pipeline script error
a2e86f4 
- make sure value isn't null before creating a new HashMap
- add test to verify
- improve error.message

Closes elastic#1789
@leehinman leehinman force-pushed the system_hashmap_null_safe branch from d6fe893 to a2e86f4 Compare October 6, 2021 01:24
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Oct 6, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-06T14:58:25.245+0000

  • Duration: 14 min 8 sec

  • Commit: bc8b58f

Test stats 🧪

Test Results
Failed 0
Passed 267
Skipped 0
Total 267

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@andrewkroh
Copy link
Copy Markdown
Member

andrewkroh commented Oct 6, 2021

Looks like it needs an elastic-package format.

[2021-10-06T01:31:12.908Z] Error: checking package failed: formatting the integration failed (path: /var/lib/jenkins/workspace/est-manager_integrations_PR-1869/src/github.com/elastic/integrations/packages/system, failFast: true): walking through the integration files failed: formatting file failed (path: /var/lib/jenkins/workspace/est-manager_integrations_PR-1869/src/github.com/elastic/integrations/packages/system/data_stream/security/_dev/test/pipeline/unknown.json): file is not formatted (path: /var/lib/jenkins/workspace/est-manager_integrations_PR-1869/src/github.com/elastic/integrations/packages/system/data_stream/security/_dev/test/pipeline/unknown.json)

andrewkroh
andrewkroh reviewed Oct 6, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm whether these changes need applied to the ForwardedEvents pipeline?

andrewkroh
andrewkroh approved these changes Oct 6, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see ForwardedEvents is fixed in a separate PR 👍 .

LGTM

@leehinman leehinman merged commit 8cc187d into elastic:master Oct 6, 2021
@leehinman leehinman deleted the system_hashmap_null_safe branch October 6, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

No one assigned

Labels

bug Something isn't working, use only for issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[system] error.message for java.util.Map.size() because "m" is null

3 participants

@leehinman @elasticmachine @andrewkroh