Skip to content

[Azure] Add ADFS Sign-In Logs support to signinlogs data stream.#16538

Closed
btrieger wants to merge 12 commits intomainfrom
azure-adfs-signinlogs
Closed

[Azure] Add ADFS Sign-In Logs support to signinlogs data stream.#16538
btrieger wants to merge 12 commits intomainfrom
azure-adfs-signinlogs

Conversation

@btrieger
Copy link
Copy Markdown
Contributor

@btrieger btrieger commented Dec 12, 2025

Proposed commit message

Add ADFS Sign-In Logs support to signinlogs data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • Review changes to ingest pipeline to support adfs signin logs and validate new fields

How to test this PR locally

Related issues

Screenshots

@btrieger btrieger requested review from a team as code owners December 12, 2025 18:23
@btrieger btrieger requested a review from a team as a code owner December 12, 2025 18:23
@andrewkroh andrewkroh added Integration:azure Azure Logs Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Dec 12, 2025
@btrieger btrieger enabled auto-merge (squash) December 15, 2025 15:46
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

elastic-vault-github-plugin-prod bot commented Dec 16, 2025 •
edited
Loading

🚀 Benchmarks report

Package azure 👍(6) 💚(5) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
firewall_logs 2398.08 1712.33 -685.75 (-28.6%) 💔

To see the full report comment with /test benchmark fullreport

@btrieger btrieger mentioned this pull request Dec 16, 2025
Merged
5 tasks
@mmahacek
Copy link
Copy Markdown
Contributor

mmahacek commented Dec 17, 2025 •
edited
Loading

#15807 just merged which routes *SignInLogs, so the changes to the event router pipeline aren't needed here.

@zmoog zmoog added the Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] label Dec 17, 2025
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Dec 17, 2025

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jan 2, 2026 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jan 8, 2026
@botelastic
Copy link
Copy Markdown

botelastic bot commented Feb 7, 2026

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Feb 7, 2026
@botelastic
Copy link
Copy Markdown

botelastic bot commented Mar 9, 2026

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic bot closed this Mar 9, 2026
auto-merge was automatically disabled March 9, 2026 03:56

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmoog zmoog zmoog approved these changes

@kcreddy kcreddy kcreddy approved these changes

@mykola-elastic mykola-elastic mykola-elastic approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:azure Azure Logs Stalled Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Azure]: Add ADFSSignInLogs to signinlogs

7 participants

@btrieger @mmahacek @elasticmachine @zmoog @kcreddy @mykola-elastic @andrewkroh