[Enhancement] Makes Sysmon Library Load events compatible with DLL ECS fields#16442
Merged
[Enhancement] Makes Sysmon Library Load events compatible with DLL ECS fields#16442
Conversation
w0rk3r
commented
Dec 9, 2025
Comment on lines
-663
to
+673
| field: file.code_signature.signed | ||
| field: file.code_signature.trusted | ||
| value: true | ||
| if: ctx.winlog?.event_data?.Signed != null && ctx.winlog.event_data.Signed == true | ||
| if: ctx.winlog?.event_data?.Signed != null && ctx.winlog.event_data.Signed == 'true' | ||
| - set: | ||
| field: file.code_signature.trusted | ||
| value: false | ||
| if: ctx.winlog?.event_data?.Signed != null && ctx.winlog.event_data.Signed != 'true' |
Contributor
Author
There was a problem hiding this comment.
This wasn't working, so I fixed it. Renamed from file.code_signature.signed to file.code_signature.trusted as signed is not a valid ECS field. ref: https://www.elastic.co/docs/reference/ecs/ecs-code_signature
w0rk3r
commented
Dec 9, 2025
Comment on lines
-663
to
+673
| field: file.code_signature.signed | ||
| field: file.code_signature.trusted | ||
| value: true | ||
| if: ctx.winlog?.event_data?.Signed != null && ctx.winlog.event_data.Signed == true | ||
| if: ctx.winlog?.event_data?.Signed != null && ctx.winlog.event_data.Signed == 'true' | ||
| - set: | ||
| field: file.code_signature.trusted | ||
| value: false | ||
| if: ctx.winlog?.event_data?.Signed != null && ctx.winlog.event_data.Signed != 'true' |
Contributor
Author
There was a problem hiding this comment.
|
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
💚 Build Succeeded
cc @w0rk3r |
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
marc-gr
approved these changes
Dec 10, 2025
Collaborator
|
Package windows - 3.3.0 containing this change is available at https://epr.elastic.co/package/windows/3.3.0/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Summary
Resolves https://github.com/elastic/ia-trade-team/issues/687
This PR aims to make Sysmon Library load events compatible with DLL ECS fields, aligning the fields with other similar data sources like Elastic Defend, MDE, and Crowdstrike.
Currently, to support Sysmon in detection rules, we need to do a lot of workarounds with EQL optional fields, which is not possible/supported when using ES|QL. So fixing the data source would make it easier to support and maintain Sysmon-related rules.
Checklist
changelog.ymlfile.