Skip to content

[O365] Add system benchmark#16120

Merged
moxarth-rathod merged 2 commits intoelastic:mainfrom
moxarth-rathod:o365-system-benchmark
Dec 1, 2025
Merged

[O365] Add system benchmark#16120
moxarth-rathod merged 2 commits intoelastic:mainfrom
moxarth-rathod:o365-system-benchmark

Conversation

@moxarth-rathod
Copy link
Contributor

Proposed commit message

o365: add system benchmark for integration quality check

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/o365 directory.
  • Run the following command to run tests.

elastic-package test -v

Related issues

@moxarth-rathod moxarth-rathod self-assigned this Nov 26, 2025
@moxarth-rathod moxarth-rathod requested a review from a team as a code owner November 26, 2025 05:54
@moxarth-rathod moxarth-rathod added enhancement New feature or request Integration:o365 Microsoft Office 365 Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Nov 26, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Nov 26, 2025

🚀 Benchmarks report

Package o365 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 2074.69 1512.86 -561.83 (-27.08%) 💔

To see the full report comment with /test benchmark fullreport

Comment on lines +68 to +85
- path: /api/v1.0/test-cel-tenant-id/activity/feed/subscriptions/content
methods: [GET]
query_params:
contentType: "Audit.General"
startTime: "{startTime:.*}"
endTime: "{endTime:.*}"
PublisherIdentifier: test-cel-tenant-id
request_headers:
Authorization:
- "Bearer CELtoken"
responses:
- status_code: 200
headers:
Content-Type:
- "application/json"
body: |-
[{"contentType": "Audit.General","contentId": "celid3","contentUri": "http://svc-o365:8082/api/v1.0/celgen1/activity/feed/audit/celid3","contentCreated": "{{ .request.vars.endTime }}","contentExpiration": "2199-05-30T17:35:00.000Z"}]
- path: /api/v1.0/celgen1/activity/feed/audit/celid3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have more than one content path? At the moment we're only exercising the content collection, and not the iteration over the different feeds.

Comment on lines +3 to +8
enum:
- b86ab9d4-fcf1-4b11-8a06-7a8f91b47fbd
- a86ab9d4-fcf1-4b11-8a06-7a8f91b47fbd
- c86ab9d4-fcf1-4b11-8a06-7a8f91b47fbd
- d86ab9d4-fcf1-4b11-8a06-7a8f91b47fbd
- e86ab9d4-fcf1-4b11-8a06-7a8f91b47fbd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not make them enum here and make it more closely align with live-data.
We could make use of cardinality. Example here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same goes for most of the Id fields.

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @moxarth-rathod

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@moxarth-rathod moxarth-rathod merged commit 1894fb2 into elastic:main Dec 1, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:o365 Microsoft Office 365 Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

o365: Add benchmarks for integration quality checks

4 participants