Skip to content

System integration improvements#1548

Merged
leehinman merged 2 commits intoelastic:masterfrom
leehinman:event_id_custom_proc
Aug 27, 2021
Merged

System integration improvements#1548
leehinman merged 2 commits intoelastic:masterfrom
leehinman:event_id_custom_proc

Conversation

@leehinman
Copy link
Copy Markdown
Contributor

@leehinman leehinman commented Aug 20, 2021 •
edited
Loading

What does this PR do?

Changes to System integration:

  • Add custom processors
  • Add event_id selection
  • Applies to Application, Security & System data_streams

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
    - [ ] If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Author's Checklist

How to test this PR locally

  • Test on Windows host

Related issues

Screenshots

Screen Shot 2021-08-20 at 10 12 46

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 20, 2021

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 20, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-26T22:27:12.662+0000

  • Duration: 15 min 37 sec

  • Commit: bac4b1d

Test stats 🧪

Test Results
Failed 0
Passed 266
Skipped 0
Total 266

Trends 🧪

Image of Build Times

Image of Tests

@masci masci added the Team:Integrations Label for the Integrations team label Aug 23, 2021
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 23, 2021

Pinging @elastic/integrations (Team:Integrations)

fearful-symmetry
fearful-symmetry approved these changes Aug 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@fearful-symmetry fearful-symmetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert on the windows stuff in particular, but the changes LGTM.

@leehinman
Copy link
Copy Markdown
Contributor Author

leehinman commented Aug 26, 2021

@P1llus can you take a look. This should address the requests that came in via Slack.

@leehinman leehinman requested a review from P1llus August 26, 2021 22:22
@leehinman
System integration improvements
b2177fe 
- Add custom processors
- Add event_id selection
- Applies to Application, Security & System data_streams
@leehinman
update changelog.yml
bac4b1d
@leehinman leehinman force-pushed the event_id_custom_proc branch from d0cbcdd to bac4b1d Compare August 26, 2021 22:26
P1llus
P1llus approved these changes Aug 27, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I know that @marc-gr has started adding in an extra check that tags are never empty in case a user removes existing tags, we don't necessarily need to add that in now though, its up to you.

@leehinman leehinman merged commit ed14521 into elastic:master Aug 27, 2021
@leehinman leehinman deleted the event_id_custom_proc branch August 27, 2021 20:23
@oleksandryz oleksandryz mentioned this pull request Sep 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@P1llus P1llus P1llus approved these changes

@fearful-symmetry fearful-symmetry fearful-symmetry approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request Team:Integrations Label for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@leehinman @elasticmachine @P1llus @fearful-symmetry @masci