Skip to content

Fix windows dashboard links#1525

Merged
fearful-symmetry merged 2 commits intoelastic:masterfrom
fearful-symmetry:windows-dashboard-fixes
Aug 17, 2021
Merged

Fix windows dashboard links#1525
fearful-symmetry merged 2 commits intoelastic:masterfrom
fearful-symmetry:windows-dashboard-fixes

Conversation

@fearful-symmetry
Copy link
Copy Markdown
Contributor

@fearful-symmetry fearful-symmetry commented Aug 13, 2021 •
edited
Loading

See: #1524

What does this PR do?

This fixes the dashboard IDs in the windows navigation visualizations.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

How to test this PR locally

  • Pull down a build
  • Navigate to the windows Dashboard. Click through the links in the middle-right, make sure they all work.

Related issues

@fearful-symmetry fearful-symmetry added the bug Something isn't working, use only for issues label Aug 13, 2021
@fearful-symmetry fearful-symmetry requested a review from a team August 13, 2021 00:11
@fearful-symmetry fearful-symmetry self-assigned this Aug 13, 2021
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 13, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-17T16:10:43.193+0000

  • Duration: 16 min 36 sec

  • Commit: 2aad9b8

Test stats 🧪

Test Results
Failed 0
Passed 266
Skipped 0
Total 266

Trends 🧪

Image of Build Times

Image of Tests

mtojek
mtojek reviewed Aug 13, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@mtojek mtojek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at the CI output and fix errors.

@fearful-symmetry
Copy link
Copy Markdown
Contributor Author

fearful-symmetry commented Aug 13, 2021

Forgot the changelog, again!

@fearful-symmetry fearful-symmetry requested review from a team and mtojek August 13, 2021 16:47
jsoriano
jsoriano approved these changes Aug 17, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fearful-symmetry fearful-symmetry merged commit f7b014d into elastic:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsoriano jsoriano jsoriano approved these changes

@mtojek mtojek Awaiting requested review from mtojek

Assignees

@fearful-symmetry fearful-symmetry

Labels

bug Something isn't working, use only for issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

System Integration - Incorrect dashboard IDs (URLs) for navigation visualizations

4 participants

@fearful-symmetry @elasticmachine @jsoriano @mtojek